Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update of Worst Practices page (Spanish version) #82

Merged
merged 2 commits into from Nov 22, 2019

Conversation

@ArCiGo
Copy link
Contributor

ArCiGo commented Nov 19, 2019

Update of page.

Note.-

I noticed that some pages of the documentation in Spanish were badly translated. I don't know if a service translator, like Google, was used but if you read the text and titles of the translated pages you will notice the literal translation.

I don't pretend to be a professional translator. It's just an observation.

image

image

image

Thanks for contributing to the Selenium site and documentation!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Motivation and Context

Types of changes

  • Change to the site (I am attaching a screenshot showing the before and after, if needed)
  • Code example added (and I also added the example to all translated languages)
  • Improved translation
  • Added new translation (and I also added a notice to each document missing translation)

CLA

Update of page.

Note.-

I noticed that some pages of the documentation in Spanish were badly translated. I don't know if a service translator, like Google, was used but if you read the text and titles of the translated pages you will notice the literal translation.

I don't pretend to be a professional translator. It's just an observation.
Copy link
Member

diemol left a comment

Thanks for your PR @ArCiGo, could you please confirm that you have signed the CLA?

@ArCiGo

This comment has been minimized.

Copy link
Contributor Author

ArCiGo commented Nov 20, 2019

Updated, @diemol !

@diemol
diemol approved these changes Nov 22, 2019
Copy link
Member

diemol left a comment

@ArCiGo thank you for your PR!
You are completely right, it just seems to be a Google Translate thing, partly my fault for not double-checking.
Would you be up to help us improving the translation? I could reset the pages to English again if you'd like.

@diemol diemol merged commit 9735254 into SeleniumHQ:master Nov 22, 2019
1 check passed
1 check passed
Travis CI - Pull Request Build Passed
Details
@ArCiGo ArCiGo changed the title Update of Wors Practices page (Spanish version) Update of Worst Practices page (Spanish version) Nov 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.