Fix specialized std::vector<bool> handling#23
Merged
Conversation
Owner
|
Hi, as you can see this breaks all GCC builds. I know that Thanks |
Contributor
Author
|
I'll look closer, I don't anticipate it to be impossible at all. |
alexey-pelykh
force-pushed
the
fix/std_vector_bool
branch
from
6f1d434 to
01a7be1
Compare
alexey-pelykh
force-pushed
the
fix/std_vector_bool
branch
from
01a7be1 to
23cf04e
Compare
Contributor
Author
|
That's one way to tackle the issue, checked on latest GCC and Clang |
Contributor
Author
|
Cool, so it passes the tests. Obviously |
Owner
|
Thanks for the PR 👍. I updated ubuntu and mac versions in the CI |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.