Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug(Popup): Clicking on another Popup's trigger doesn't close open Popups. #1251

Closed
keeslinp opened this issue Jan 30, 2017 · 6 comments · Fixed by #1273
Closed

Bug(Popup): Clicking on another Popup's trigger doesn't close open Popups. #1251

keeslinp opened this issue Jan 30, 2017 · 6 comments · Fixed by #1273

Comments

@keeslinp
Copy link
Contributor

keeslinp commented Jan 30, 2017

Steps

  1. Open an on="click" popup
  2. Click on another trigger for a different on="click" popup while the first is still open

Expected Result

The first Popup should close and the second should open

Actual Result

Both Popups stay open.

Version

0.64.4

Testcase

Here's an example:
http://codepen.io/anon/pen/XpVqKq

It happens on the doc page as well:

screen shot 2017-01-30 at 9 53 14 am

@levithomason
Copy link
Member

Yep, the trigger click handler is stopping propagation. We should instead be checking if the click was inside the trigger node, rather than stopping the event from propagating.

https://github.com/Semantic-Org/Semantic-UI-React/blob/master/src/addons/Portal/Portal.js#L249

@levithomason
Copy link
Member

PR coming.

@levithomason
Copy link
Member

Released in semantic-ui-react@0.64.7.

@Ivaylo-Bachvarov
Copy link

The issue seems to be back:
image

@bwoodlt
Copy link
Contributor

bwoodlt commented Jul 13, 2018

Any update on this issue? I'm having exactly the same experience as described above.

@layershifter
Copy link
Member

Please don't post anything in the old closed issues. If you have an issue, please fill a new issue with issue template.

@Semantic-Org Semantic-Org locked as resolved and limited conversation to collaborators Jul 13, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants