Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Portal): focus is stolen when clicking away to close #1271

Closed
levithomason opened this issue Feb 1, 2017 · 1 comment · Fixed by #1273
Closed

fix(Portal): focus is stolen when clicking away to close #1271

levithomason opened this issue Feb 1, 2017 · 1 comment · Fixed by #1273
Assignees
@levithomason
Labels
bug

Comments

@levithomason
Copy link
Member

levithomason commented Feb 1, 2017 •
edited
Loading

Introduced in #1154, the Portal steals focus from other controls on close.

Steps

  1. Create a popup that opens on click
  2. Click the trigger to open the popup
  3. Click an input element outside of the popup to focus it

Expected Result

The popup should close and the input should receive focus.

Actual Result

The popup closes, but the popup's trigger steals focus from the input.

Version

0.64.5

Testcase

http://codepen.io/levithomason/pen/MJVoQY
@levithomason levithomason self-assigned this Feb 1, 2017
@levithomason levithomason mentioned this issue Feb 2, 2017
Merged
@levithomason
Copy link
Member Author

Released in semantic-ui-react@0.64.7.

@levithomason levithomason mentioned this issue Feb 13, 2017
Closed
@levithomason levithomason mentioned this issue Feb 21, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@levithomason levithomason

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(Portal): fix several event related behaviors Semantic-Org/Semantic-UI-React
1 participant
@levithomason