Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Segment): using loading and clearing together makes clearing lose its effect #1385

Closed
rkosafo opened this issue Feb 24, 2017 · 1 comment

Comments

@rkosafo
Copy link

rkosafo commented Feb 24, 2017

Steps to Reproduce

  1. Using the loading sample, replace image with right floated button
  2. Add clearing to the segment

Expected
The Segment should be large enough to contain the button.

Result
The Segment shrinks in size as if clearing has not been applied.

Testcase
If the docs show the issue, use: http://react.semantic-ui.com/elements/segment
Otherwise, fork this to get started: http://codepen.io/levithomason/pen/ZpBaJX

import React from 'react'
import { Image, Segment, Button } from 'semantic-ui-react'

const SegmentExampleLoading = () => (
  <Segment clearing loading>
    <Button floated="right">Test</Button>
  </Segment>
)

export default SegmentExampleLoading
@levithomason
Copy link
Member

As with #1384, this also seems sane to me, however, this is also a CSS issue and therefore should be posted on https://github.com/Semantic-Org/Semantic-UI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants