Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Message with both icon and compact props does not become compact #2280

Closed
hanshenrik opened this issue Nov 1, 2017 · 3 comments
Closed

Message with both icon and compact props does not become compact #2280

hanshenrik opened this issue Nov 1, 2017 · 3 comments

Comments

@hanshenrik
Copy link

Steps

  1. Go to https://react.semantic-ui.com/collections/message#message-example-icon-prop
  2. Give the Icon Message example a compact prop

Expected Result

The Message should become compact, like non-icon Message components

Actual Result

The Message stays fluid.

Version

0.75.1

Testcase

https://react.semantic-ui.com/collections/message#message-example-icon-prop
Add a compact prop and remove/add the icon prop to see how this affects the compact styling

@brianespinosa
Copy link
Member

Hi @hanshenrik, thanks for the report. Checking the markup that is generated, all of the correct class names are present for that combination of props ui compact icon message. This is actually an issue in the CSS, specifically because the icon message type is switching to display: flex in order to achieve that layout. You will see the same thing if you modify the markup in SUI core docs here: https://semantic-ui.com/collections/message.html#icon-message

I'd encourage you to open a CSS issue on the SUI core repository for this: https://github.com/Semantic-Org/Semantic-UI/issues

@hanshenrik
Copy link
Author

Thanks for the quick response.

The issue is addressed here: Semantic-Org/Semantic-UI#4759

@lubber-de

This comment was marked as spam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants