Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Dropdown): multiple search dropdown should refocus the search on select of an option #1257

Merged
merged 1 commit into from
Jan 31, 2017
Merged

feat(Dropdown): multiple search dropdown should refocus the search on select of an option #1257

merged 1 commit into from
Jan 31, 2017

Conversation

apiv
Copy link
Contributor

@apiv apiv commented Jan 30, 2017

fixes issue #1243

Before:
before

After:
after

@levithomason levithomason changed the title bug(Dropdown): multiple search dropdown should refocus the search on select of an option fix(Dropdown): multiple search dropdown should refocus the search on select of an option Jan 30, 2017
@levithomason
Copy link
Member

Checked out the code here and tried the component. Looks great, thanks! Could we get an assertion for this behavior as well? There is a describe('selecting items', ... ') around line 1094 (nested in describe('multiple', ... )) in Dropdown-test.js that could house the it() for this.

The wrapperMount method will mount the dropdown to the document so you can check the activeElement in tests for focus assertions.

@apiv apiv force-pushed the feature/Dropdown-focus-on-change branch from 4ba7174 to 9c7e036 Compare January 31, 2017 01:16
@apiv
Copy link
Contributor Author

apiv commented Jan 31, 2017

Sure thing, glad to contribute, our app uses semantic-ui-react as the base for most of our UI. I've added the assertion and rebased / re-pushed.

@apiv apiv force-pushed the feature/Dropdown-focus-on-change branch 2 times, most recently from 0ae89aa to acec9d0 Compare January 31, 2017 01:38
@apiv apiv force-pushed the feature/Dropdown-focus-on-change branch from acec9d0 to 18dac35 Compare January 31, 2017 01:48
@levithomason levithomason changed the title fix(Dropdown): multiple search dropdown should refocus the search on select of an option feat(Dropdown): multiple search dropdown should refocus the search on select of an option Jan 31, 2017
@levithomason levithomason merged commit 9cdbf9e into Semantic-Org:master Jan 31, 2017
@levithomason
Copy link
Member

Superb, thanks for the rapid update 👍

@levithomason
Copy link
Member

Released in semantic-ui-react@0.64.7.

harel pushed a commit to harel/Semantic-UI-React that referenced this pull request Feb 18, 2017
@apiv @harel
feat(Dropdown): multiple search dropdown should refocus the search on…
7c82ae0 
… select of an option (Semantic-Org#1257)

feat(Dropdown): multiple search dropdown should refocus the search on select of an option
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@apiv @levithomason