Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Dropdown): add DropdownSearchInput component #1619

Merged
merged 14 commits into from Jul 7, 2017
Merged

feat(Dropdown): add DropdownSearchInput component #1619

merged 14 commits into from Jul 7, 2017

Conversation

layershifter
Copy link
Member

@layershifter layershifter commented Apr 24, 2017 •
edited

Replaces #1481, discussion is there.

@codecov-io
Copy link

codecov-io commented Apr 24, 2017 •
edited

Codecov Report

Merging #1619 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1619      +/-   ##
==========================================
+ Coverage   99.75%   99.75%   +<.01%     
==========================================
  Files         144      145       +1     
  Lines        2463     2475      +12     
==========================================
+ Hits         2457     2469      +12     
  Misses          6        6
Impacted Files Coverage Δ
src/modules/Dropdown/Dropdown.js 100% <100%> (ø) ⬆️
src/modules/Dropdown/DropdownSearchInput.js 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c194992...9151ead. Read the comment docs.

layershifter
layershifter commented Apr 25, 2017
View reviewed changes
Copy link
Member Author

@layershifter layershifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@levithomason we are ready for review there 😄

layershifter
layershifter commented May 7, 2017
View reviewed changes
Copy link
Member Author

@layershifter layershifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've rebased to master and fixed lint issue. Ready for review

Alexander Fedyashov added 2 commits May 25, 2017 10:41
Merge branch 'master' of https://github.com/Semantic-Org/Semantic-UI-…
2d6da49 
…React into feat/dropdown-search-input

# Conflicts:
#	src/modules/Dropdown/Dropdown.js
style(Dropdown): style updates
e2ef8b3
layershifter
layershifter commented May 25, 2017
View reviewed changes
Copy link
Member Author

@layershifter layershifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR was updated to master, merge conflicts were solved.

@layershifter layershifter mentioned this pull request May 31, 2017
Closed
levithomason
levithomason reviewed Jun 7, 2017
View reviewed changes
src/modules/Dropdown/DropdownSearchInput.js Outdated
]),

/** A width of an input. */
width: PropTypes.oneOfType([
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer we just use the width property within the style prop instead of breaking it out into a separate prop. This way, all style props are always within style and there is no guessing about which style props are top-level props.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the feedback, will do 👍

layershifter
layershifter commented Jun 8, 2017
View reviewed changes
Copy link
Member Author

@layershifter layershifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@levithomason I've performed requested changes, width and style props were removed, unnecessary tests, too 👍

Alexander Fedyashov added 3 commits June 15, 2017 12:15
Merge branch 'master' of https://github.com/Semantic-Org/Semantic-UI-…
2a15cb2 
…React into feat/dropdown-search-input

# Conflicts:
#	src/modules/Dropdown/Dropdown.js
#	test/specs/modules/Dropdown/Dropdown-test.js
fix(Dropdown): update after merge
10e8a06
fix(Dropdown): update after merge
b3431c1
Merge branches 'feat/dropdown-search-input' and 'master' of https://g…
9151ead 
…ithub.com/Semantic-Org/Semantic-UI-React into feat/dropdown-search-input

# Conflicts:
#	src/modules/Dropdown/Dropdown.js
@levithomason levithomason merged commit e6cdac6 into master Jul 7, 2017
@levithomason levithomason deleted the feat/dropdown-search-input branch July 7, 2017 14:57
@levithomason
Copy link
Member

Released in semantic-ui-react@0.71.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@levithomason levithomason levithomason left review comments

Assignees
No one assigned
Labels
enhancement ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@layershifter @codecov-io @levithomason