perf(lodash): remove _.omit and _.isEqual #2111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2111 +/- ##
==========================================
+ Coverage 99.76% 99.76% +<.01%
==========================================
Files 151 151
Lines 2602 2606 +4
==========================================
+ Hits 2596 2600 +4
Misses 6 6
Continue to review full report at Codecov.
|
layershifter
force-pushed
the
pref/lodash
branch
from
a2461cf
to
6fd65f7
Compare
|
Released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #864
Most tasks there were complete. This PR removes the final two methods with perf issues, omit and isEqual. We've already optimized lodash in the bundle by picking only the methods we use.