Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(README): fix link to CSS Usage page #3212

Merged
merged 1 commit into from Oct 12, 2018

Conversation

jahvi
Copy link
Contributor

@jahvi jahvi commented Oct 12, 2018

The CSS Usage link markdown wasn't being processed, I just added an empty line before to make this work.

@welcome
Copy link

welcome bot commented Oct 12, 2018

💖 Thanks for opening this pull request! 💖

Here is a list of things that will help get it across the finish line:

  • Run yarn lint locally to catch formatting errors. This will fix some errors automatically, commit and push any changes.
  • Run yarn test locally to catch errors. This ensures all components still behave as they should.
  • Run yarn start to run the doc site locally and try a few pages, ensuring everything is in good working order.
  • Include tests when adding/changing behavior.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@jahvi jahvi changed the title Fix link to CSS Usage in README docs(README): fix link to CSS Usage page Oct 12, 2018
@codecov-io
Copy link

codecov-io commented Oct 12, 2018

Codecov Report

Merging #3212 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3212   +/-   ##
=======================================
  Coverage   99.92%   99.92%           
=======================================
  Files         169      169           
  Lines        2790     2790           
=======================================
  Hits         2788     2788           
  Misses          2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 201ff7a...bff6c54. Read the comment docs.

@layershifter layershifter merged commit daf71d5 into Semantic-Org:master Oct 12, 2018
@welcome
Copy link

welcome bot commented Oct 12, 2018

Congrats on merging your first pull request! 🎉🎉🎉

robot victory dance

@layershifter
Copy link
Member

❤️

@levithomason
Copy link
Member

Released in semantic-ui-react@0.83.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants