Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Accordion): add `icon` shorthand for AccordionTitle #3417

Merged
merged 7 commits into from Feb 11, 2019

Conversation

@sako9
Copy link
Contributor

sako9 commented Feb 6, 2019

Added an example on how to add a custom icon via the standard Shorthand

Added an example on how to add a custom icon via the standard Shorthand
@welcome

This comment has been minimized.

Copy link

welcome bot commented Feb 6, 2019

💖 Thanks for opening this pull request! 💖

Here is a list of things that will help get it across the finish line:

  • Run yarn lint locally to catch formatting errors. This will fix some errors automatically, commit and push any changes.
  • Run yarn test locally to catch errors. This ensures all components still behave as they should.
  • Run yarn start to run the doc site locally and try a few pages, ensuring everything is in good working order.
  • Include tests when adding/changing behavior.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

sako9
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Feb 7, 2019

Codecov Report

Merging #3417 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3417      +/-   ##
==========================================
- Coverage   99.92%   99.89%   -0.04%     
==========================================
  Files         172      172              
  Lines        2837     2835       -2     
==========================================
- Hits         2835     2832       -3     
- Misses          2        3       +1
Impacted Files Coverage Δ
src/modules/Dropdown/Dropdown.js 99.76% <0%> (-0.24%) ⬇️
src/modules/Checkbox/Checkbox.js 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab582ed...d0bc4c9. Read the comment docs.

@layershifter layershifter changed the title docs(AccordionExampleStandardShorthand): Custom Title Icon Example feat(Accordion): add `icon` shorthand for AccordionTitle Feb 11, 2019
Copy link
Contributor Author

sako9 left a comment

Looks good!

@sako9 sako9 closed this Feb 11, 2019
@layershifter layershifter reopened this Feb 11, 2019
@layershifter layershifter merged commit 0d28f12 into Semantic-Org:master Feb 11, 2019
3 checks passed
3 checks passed
ci/circleci Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 99.92%)
Details
codecov/project 99.92% (+<.01%) compared to ab582ed
Details
@welcome

This comment has been minimized.

Copy link

welcome bot commented Feb 11, 2019

Congrats on merging your first pull request! 🎉🎉🎉

robot victory dance

@sako9 sako9 deleted the sako9:patch-1 branch Feb 11, 2019
@levithomason

This comment has been minimized.

Copy link
Member

levithomason commented Mar 13, 2019

Released in semantic-ui-react@0.86.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.