Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(Dropdown): remove deprecated lifecycle method from DropdownExampleRemote #3529

Conversation

@grumblerchester
Copy link
Contributor

grumblerchester commented Mar 20, 2019

Relates to #2732

Commit includes automatic formatting changes by lint.
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Mar 20, 2019

Codecov Report

Merging #3529 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3529   +/-   ##
=======================================
  Coverage   99.82%   99.82%           
=======================================
  Files         172      172           
  Lines        2795     2795           
=======================================
  Hits         2790     2790           
  Misses          5        5

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 869f4e7...f0b0389. Read the comment docs.

@layershifter layershifter changed the title docs(Dropdown): Remove deprecated lifecycle method from DropdownExampleRemote. docs(Dropdown): Remove deprecated lifecycle method from DropdownExampleRemote Mar 21, 2019
@layershifter layershifter changed the title docs(Dropdown): Remove deprecated lifecycle method from DropdownExampleRemote docs(Dropdown): remove deprecated lifecycle method from DropdownExampleRemote Mar 21, 2019
@layershifter layershifter added the docs label Mar 21, 2019
@layershifter layershifter merged commit 3db04da into Semantic-Org:master Mar 21, 2019
3 checks passed
3 checks passed
ci/circleci Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 869f4e7...f0b0389
Details
codecov/project 99.82% remains the same compared to 869f4e7
Details
@welcome

This comment has been minimized.

Copy link

welcome bot commented Mar 21, 2019

Congrats on merging your first pull request! 🎉🎉🎉

robot victory dance

@grumblerchester grumblerchester deleted the grumblerchester:remove-legacy-lifecycle-from-dropdown-example branch Mar 21, 2019
mbakiev added a commit to mbakiev/Semantic-UI-React that referenced this pull request Jun 17, 2019
…leRemote (Semantic-Org#3529)

* docs(Dropdown): Remove deprecated lifecycle method.

Commit includes automatic formatting changes by lint.

* Update DropdownExampleRemote.js

* Update DropdownExampleRemote.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.