Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Popup): add `eventsEnabled` prop #3715

Merged
merged 3 commits into from Jul 24, 2019
Merged

Conversation

@layershifter
Copy link
Member

layershifter commented Jul 22, 2019

Fixes #3700.

This PR adds eventsEnabled prop to Popup component that allows to disable PopperJS event handlers.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jul 22, 2019

Codecov Report

Merging #3715 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3715   +/-   ##
=======================================
  Coverage   99.83%   99.83%           
=======================================
  Files         175      175           
  Lines        3120     3120           
=======================================
  Hits         3115     3115           
  Misses          5        5
Impacted Files Coverage Δ
src/modules/Popup/Popup.js 98.68% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 048bd35...9389be1. Read the comment docs.

@layershifter layershifter merged commit c86e198 into master Jul 24, 2019
3 checks passed
3 checks passed
ci/circleci Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 99.83%)
Details
codecov/project 99.83% (+0%) compared to 048bd35
Details
@delete-merged-branch delete-merged-branch bot deleted the feat/popup-events-enabled branch Jul 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.