Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(Search): fix wrong description for `input` shorthand #3727

Merged
merged 3 commits into from Aug 4, 2019

Conversation

@ablakey
Copy link
Contributor

ablakey commented Aug 1, 2019

Diff is self explanatory. The documentation for the Search.input proptype is not accurate.

@welcome

This comment has been minimized.

Copy link

welcome bot commented Aug 1, 2019

💖 Thanks for opening this pull request! 💖

Here is a list of things that will help get it across the finish line:

  • Run yarn lint locally to catch formatting errors. This will fix some errors automatically, commit and push any changes.
  • Run yarn test locally to catch errors. This ensures all components still behave as they should.
  • Run yarn start to run the doc site locally and try a few pages, ensuring everything is in good working order.
  • Include tests when adding/changing behavior.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@layershifter layershifter added the docs label Aug 4, 2019
@layershifter layershifter changed the title Fix wrong documentation for Search `input`. docs(Search): fix wrong description for `input` shorthand Aug 4, 2019
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Aug 4, 2019

Codecov Report

Merging #3727 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3727      +/-   ##
==========================================
- Coverage   99.83%   99.83%   -0.01%     
==========================================
  Files         175      175              
  Lines        3122     3120       -2     
==========================================
- Hits         3117     3115       -2     
  Misses          5        5
Impacted Files Coverage Δ
src/modules/Search/Search.js 99.54% <ø> (ø) ⬆️
src/modules/Checkbox/Checkbox.js 100% <0%> (ø) ⬆️
src/modules/Transition/Transition.js 100% <0%> (ø) ⬆️
src/views/Feed/FeedContent.js 100% <0%> (ø) ⬆️
src/modules/Dropdown/Dropdown.js 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f50550c...5a56c6a. Read the comment docs.

@layershifter layershifter merged commit 781a1ff into Semantic-Org:master Aug 4, 2019
1 check passed
1 check passed
ci/circleci Your tests passed on CircleCI!
Details
@welcome

This comment has been minimized.

Copy link

welcome bot commented Aug 4, 2019

Congrats on merging your first pull request! 🎉🎉🎉

robot victory dance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.