Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typings): add missing `StrictMenuProps` type export #3755


Copy link

b-smets commented Aug 21, 2019

The type definition was missing an export for StrictMenuprops in the top level type definition file.


This comment has been minimized.

Copy link

welcome bot commented Aug 21, 2019

💖 Thanks for opening this pull request! 💖

Here is a list of things that will help get it across the finish line:

  • Run yarn lint locally to catch formatting errors. This will fix some errors automatically, commit and push any changes.
  • Run yarn test locally to catch errors. This ensures all components still behave as they should.
  • Run yarn start to run the doc site locally and try a few pages, ensuring everything is in good working order.
  • Include tests when adding/changing behavior.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.


This comment has been minimized.

Copy link

codecov-io commented Aug 21, 2019

Codecov Report

Merging #3755 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3755   +/-   ##
  Coverage   99.84%   99.84%           
  Files         175      175           
  Lines        3125     3125           
  Hits         3120     3120           
  Misses          5        5

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea950cb...25104a7. Read the comment docs.

@layershifter layershifter changed the title Add missing StrictMenuProps type export fix(typings): add missing `StrictMenuProps` type export Aug 21, 2019
@layershifter layershifter merged commit 07b318a into Semantic-Org:master Aug 21, 2019
3 checks passed
3 checks passed
ci/circleci Your tests passed on CircleCI!
codecov/patch Coverage not affected when comparing ea950cb...25104a7
codecov/project 99.84% remains the same compared to ea950cb

This comment has been minimized.

Copy link

welcome bot commented Aug 21, 2019

Congrats on merging your first pull request! 🎉🎉🎉

robot victory dance

@b-smets b-smets deleted the b-smets:add-missing-strictmenuprops-typing-export branch Aug 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
3 participants
You can’t perform that action at this time.