Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Dropdown): closing the search menu on spacebar press #3766

Merged

Conversation

@honzajerabek
Copy link
Contributor

honzajerabek commented Aug 29, 2019

Fixes the #3764 .

In tests, I've only focused on open/closed state of the Dropdown components, because DropdownItem gets automatically set active and selected, which is probably a different issue (#3130 ), so I decided not to dig into it.

@welcome

This comment has been minimized.

Copy link

welcome bot commented Aug 29, 2019

💖 Thanks for opening this pull request! 💖

Here is a list of things that will help get it across the finish line:

  • Run yarn lint locally to catch formatting errors. This will fix some errors automatically, commit and push any changes.
  • Run yarn test locally to catch errors. This ensures all components still behave as they should.
  • Run yarn start to run the doc site locally and try a few pages, ensuring everything is in good working order.
  • Include tests when adding/changing behavior.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Aug 29, 2019

Codecov Report

Merging #3766 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3766   +/-   ##
=======================================
  Coverage   99.84%   99.84%           
=======================================
  Files         175      175           
  Lines        3125     3125           
=======================================
  Hits         3120     3120           
  Misses          5        5
Impacted Files Coverage Δ
src/modules/Dropdown/Dropdown.js 100% <ø> (ø) ⬆️
src/modules/Popup/Popup.js 98.71% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81d3cd1...1ab871d. Read the comment docs.

@evanstern

This comment has been minimized.

Copy link

evanstern commented Aug 29, 2019

👍 Thanks for getting this done so fast!

Copy link

ambroselittle left a comment

Seems like the right quick fix for this.

layershifter added 2 commits Sep 2, 2019
Copy link
Member

layershifter left a comment

Tested in manually, works like a chart 💎

Thank you for fixing this ❤️

@layershifter layershifter merged commit a4b8757 into Semantic-Org:master Sep 2, 2019
1 check passed
1 check passed
ci/circleci Your tests passed on CircleCI!
Details
@welcome

This comment has been minimized.

Copy link

welcome bot commented Sep 2, 2019

Congrats on merging your first pull request! 🎉🎉🎉

robot victory dance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.