Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(Ref): use component from Stardust UI #3774

Merged
merged 3 commits into from Sep 6, 2019
Merged

chore(Ref): use component from Stardust UI #3774

merged 3 commits into from Sep 6, 2019

Conversation

@layershifter
Copy link
Member

layershifter commented Sep 6, 2019

This PR is a part of convergence effort between Semantic UI React & Stardust UI.

馃敭 Ref component is reexported from Stardust UI

Stardust UI has the same Ref component as Semantic UI. To simplify maintenance we will support Ref component only under Stardust.

Docs for this component will be also removed from Semantic UI, but still will be available under Stardust: https://stardust-ui.github.io/react/components/ref/definition

These changes should not affect you as SUIR user, however.

馃槰 Possible breaking changes

Things below were never advertised as public API, but should be mentioned:

  • TypeScript interfaces StrictRefProps, RefFindNodeProps, StrictRefFindNodeProps, RefForwardProps, StrictRefForwardProps are no longer exported.
  • RefFindNode & RefForward components are no longer exported.

Also bumps react-popper to latest.

@layershifter layershifter force-pushed the chore/reuse-ref branch from 9ca1fa5 to 8defc07 Sep 6, 2019
@layershifter layershifter added the chore label Sep 6, 2019
@layershifter layershifter force-pushed the chore/reuse-ref branch from 8defc07 to be751f2 Sep 6, 2019
@layershifter layershifter changed the title chore(Ref): use component from Stardust chore(Ref): use component from Stardust UI Sep 6, 2019
@layershifter layershifter marked this pull request as ready for review Sep 6, 2019
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Sep 6, 2019

Codecov Report

Merging #3774 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3774      +/-   ##
==========================================
- Coverage   99.84%   99.83%   -0.01%     
==========================================
  Files         175      172       -3     
  Lines        3125     3101      -24     
==========================================
- Hits         3120     3096      -24     
  Misses          5        5
Impacted Files Coverage 螖
src/elements/Button/Button.js 95.45% <酶> (酶) 猬嗭笍
src/modules/Checkbox/Checkbox.js 100% <酶> (酶) 猬嗭笍
src/modules/Sticky/Sticky.js 99.09% <酶> (酶) 猬嗭笍
src/addons/Portal/PortalInner.js 100% <酶> (酶) 猬嗭笍
src/modules/Dimmer/DimmerInner.js 100% <酶> (酶) 猬嗭笍
src/addons/Portal/Portal.js 100% <酶> (酶) 猬嗭笍
src/modules/Dropdown/Dropdown.js 100% <酶> (酶) 猬嗭笍
src/modules/Modal/Modal.js 100% <酶> (酶) 猬嗭笍
src/addons/TextArea/TextArea.js 100% <酶> (酶) 猬嗭笍
src/behaviors/Visibility/Visibility.js 100% <酶> (酶) 猬嗭笍
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update a4b8757...8a400c5. Read the comment docs.

@layershifter layershifter merged commit 62d2fed into master Sep 6, 2019
4 checks passed
4 checks passed
License Compliance All checks passed.
Details
ci/circleci Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 99.84%)
Details
codecov/project Absolute coverage decreased by -<.01% but relative coverage increased by +0.15% compared to a4b8757
Details
@delete-merged-branch delete-merged-branch bot deleted the chore/reuse-ref branch Sep 6, 2019
@montogeek

This comment has been minimized.

Copy link

montogeek commented Sep 27, 2019

@layershifter Sorry for mention you here, What does it mean "convergence effort between Semantic UI React & Stardust UI."? StardustUI provides the JS/component part and SemanticUI the style/look and feel part? It is to make the core lightweight?

@layershifter

This comment has been minimized.

Copy link
Member Author

layershifter commented Sep 27, 2019

@montogeek

Stardust UI was forked from SUIR, in the current state components there have a bit different API, design and ideas. To clarify, Stardust is more accessible, uses CSS-in-JS for styles and has some API changes in shorthands that were implemented based on consumers feedback and our experience. However, there are also caveats, it's less stable, supports less features and don't offer other themes than Teams.

However, there is a lot of things that can and should be shared. At least to simplify maintenance, first it's a Ref component that is totally same. Next things will be probably shorthand factories and some React hooks for internal implementation that will allow to get accessibility improvements and simplify components like Dropdown.

StardustUI provides the JS/component part and SemanticUI the style/look and feel part?

In the end we will probably end with this, but it's a long ride 馃殫 Currently, just converge utils.

@montogeek

This comment has been minimized.

Copy link

montogeek commented Sep 27, 2019

Sounds really good, specially the CSSinJS use, overriding SUI specificity is hard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can鈥檛 perform that action at this time.