Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Button): pass focus options #4399

Merged
merged 1 commit into from Nov 22, 2022

Conversation

meltyshev
Copy link
Contributor

According to https://developer.mozilla.org/en-US/docs/Web/API/HTMLElement/focus the focus method can have an options parameter, which is useful, for example, to prevent scrolling. With this fix, options parameter is passed to the referenced DOM element.

@codecov-commenter
Copy link

codecov-commenter commented Nov 11, 2022

Codecov Report

Base: 99.75% // Head: 99.75% // No change to project coverage 👍

Coverage data is based on head (bd416d3) compared to base (c3cbcae).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4399   +/-   ##
=======================================
  Coverage   99.75%   99.75%           
=======================================
  Files         180      180           
  Lines        3248     3248           
=======================================
  Hits         3240     3240           
  Misses          8        8           
Impacted Files Coverage Δ
src/elements/Button/Button.js 95.55% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@layershifter layershifter merged commit be9c744 into Semantic-Org:master Nov 22, 2022
@welcome
Copy link

welcome bot commented Nov 22, 2022

Congrats on merging your first pull request! 🎉🎉🎉

robot victory dance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants