[bug] onRate() for .ui.ratings is always called #3712

Closed
cwbit opened this Issue Feb 18, 2016 · 1 comment

Projects

None yet

2 participants

@cwbit
cwbit commented Feb 18, 2016

There is a bug with .ui.ratings where the onRate() for .ui.ratings is always called (i.e. on page load) even before the user has interacted with it. This means all on-page ratings can fire API calls even if the user has not actually interacted with it yet.

Here is an example.

@jlukic I'm also including your response to this from Gitter just in case

@cwbit It does seem the case, looks like rating needs a fireOnInit setting like checkbox
https://github.com/qualialabs/qualia/blob/dev/app/client/lib/semantic_ui/definitions/modules/checkbox.js#L773
Probably should default to false
@cwbit this seems very clearly to be a bug, derp

@cwbit cwbit changed the title from [bug] `onRate()` for `.ui.ratings` is *always* called to [bug] onRate() for .ui.ratings is always called Feb 18, 2016
@jlukic jlukic added this to the 2.1.9 milestone Feb 18, 2016
@jlukic
Member
jlukic commented Feb 18, 2016

Thanks for filing

@jlukic jlukic closed this Feb 19, 2016
@jlukic jlukic modified the milestone: 2.1.9, 2.2 May 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment