Gulp task help descriptors incorrect #3858

Closed
ewhance opened this Issue Mar 22, 2016 · 4 comments

Projects

None yet

2 participants

@ewhance
ewhance commented Mar 22, 2016

Good Morning,

I noticed that the help comments are switched on two tasks, build-rtl reads "Watch files as RTL" and watch-rtl reads "Build all files as RTL".

I was also curious if there could be an effort to remove unneeded tasks conditionally based on your install options. Since I chose to not include RTL in my install, I would prefer that those tasks not be included.

Thanks,
ewh

@jlukic
Member
jlukic commented Mar 22, 2016

These tasks are removed conditionally based on rtl config.
https://github.com/Semantic-Org/Semantic-UI/blob/master/gulpfile.js#L76

The descriptors are indeed incorrect, I'll fix.

@jlukic jlukic added this to the 2.1.9 milestone Mar 22, 2016
@ewhance
ewhance commented Mar 23, 2016

Thanks for the reply jlukic.

I did notice that there were conditional statements in ./semantic/gulpfile.js that should be working. Perhaps it is specific to my usage somehow. I'm working in VS2015 (using the task runner explorer), followed the recipes/advanced-usage guide on semantic-ui.com, and imported the watch and build tasks with the specified path (/semantic/tasks/watch and build); However, I have not been able to observe any impact to the tasks when the /semantic/gulpfile.js is edited or even entirely commented out. There doesn't seem to be any caching going on either. I suspect that the expected inheritance is not occurring. By chance are you familiar with this issue?

@ewhance
ewhance commented Mar 23, 2016

I've also found that I actually have the gulpfile.js from https://github.com/Semantic-Org/Semantic-UI/blob/master/tasks/config/npm/gulpfile.js at /Semantic/gulpfile.js as well as at /Semantic/tasks/config/npm/gulpfile.js instead of the one you linked. Perhaps this is an issue?

@jlukic jlukic added a commit that referenced this issue Mar 29, 2016
@jlukic jlukic Fixes #3858 issue with gulp rtl tasks 7333ca8
@jlukic
Member
jlukic commented Mar 29, 2016

That is correct, there's actually two ways to install, from npm install semantic-ui and gulp install

I've modified the help text to swap them back

@jlukic jlukic closed this Mar 29, 2016
@jlukic jlukic modified the milestone: 2.1.9, 2.2 May 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment