npm WARN "deprecated gulp-minify-css" on semantic-ui 2.2.3 #4463

Closed
neokio opened this Issue Aug 22, 2016 · 2 comments

Projects

None yet

2 participants

@neokio
neokio commented Aug 22, 2016

When doing an npm update, semantic went from 2.2.2 to 2.2.3, and this error appeared:

UNMET PEER DEPENDENCY gulp-minify-css@*
npm WARN semantic-ui@2.2.3 requires a peer of gulp-minify-css@* but none was installed.
npm WARN deprecated gulp-minify-css@1.2.4: Please use gulp-clean-css

Solved with a simple npm install gulp-minify-css --save-dev, of course, but you know, when npm says an unmet peer is deprecated, I get a bit queasy and gassy ;)

@jlukic
Member
jlukic commented Aug 22, 2016

minify-css is no longer being used. We've updated to clean-css in 2.2.3 unfortunately forgot to wipe it from the package.json will remove in next bump.

@jlukic jlukic added this to the 2.2.4 milestone Aug 22, 2016
@jlukic jlukic removed this from the 2.2.5 milestone Aug 25, 2016
@jlukic
Member
jlukic commented Aug 25, 2016

Fixed in 2.2.4

@jlukic jlukic closed this Aug 25, 2016
@jlukic jlukic added a commit that referenced this issue Aug 25, 2016
@jlukic jlukic #4463 - remove bad dep 190e8e5
@jlukic jlukic added this to the 2.2.4 milestone Aug 25, 2016
@ali1k ali1k added a commit to slidewiki/custom-semantic-ui that referenced this issue Oct 14, 2016
@ali1k ali1k Merge branch 'master' of https://github.com/Semantic-Org/Semantic-UI
* 'master' of https://github.com/Semantic-Org/Semantic-UI: (62 commits)
  Fix fg-color on inverted forms in Flat theme.
  Add transition fallback to progress
  Rebuild 2.2.4
  #4463 - remove bad dep
  Build 2.2.4
  Fixes missing message var
  Revert "zone.js/issues/319 Loosen equality on undefined check for determining input event"
  Fix typos in rlsnotes 2.2.3
  Finalize release notes 2.2.3
  Build 2.2.3
  #4284 - Fixes obvious brand colors.. tbd instagram
  Add iconPath duplication to avoid reqing material site theme
  #4412, redo paths to be more consistent with default theme
  Rlsnotes #4399
  #4403 cred
  #4408 - adds cred
  Fixes comment sizing #4408
  Fix point-events typo #4408
  Update icon.variables
  Corrected for missing <i> selector
  ...
81d9442
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment