Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Animated Buttons] should animate in Chrome #6663

Open
5t4r8ucK opened this issue Nov 9, 2018 · 5 comments
Open

[Animated Buttons] should animate in Chrome #6663

5t4r8ucK opened this issue Nov 9, 2018 · 5 comments

Comments

@5t4r8ucK
Copy link

5t4r8ucK commented Nov 9, 2018

I used dragonfire1119's solution for card shuffling found here: #3353 (comment). Originally it worked fine but when I added animated buttons to the cards the text and animations completely disappeared in Chrome/Opera. Works fine in FF.

I noticed that when I removed the 'display: block' property the animations were back however that defeats the whole purpose of creating a masonry like layout. The only solution for this bug that I found is to add this to my CSS:

.ui.animated.button {
will-change: contents;
z-index: initial;
}

I'm not 100% certain why this works and why the original doesn't. Is this perhaps a Chrome bug? It does after all work in FF just fine. Also is there a reason for why the z-index is set to 1 initially? Will setting it to 'initial' break something else down the line?

Steps

  1. Set up the layout in the same way as the layout in the above link.
  2. Open in Chrome
  3. Hover over any button with the animated class.

Expected Result

The hover animation should show up in Chrome like it does in FF.

Actual Result

No text or animation is displayed in Chrome upon hover.

Version

2.4

Testcase

https://jsfiddle.net/St4r8ucK/cr4qwm29/5/

@y0hami
Copy link
Member

y0hami commented Nov 10, 2018

I can't seem to reproduce this, the animations work for me.

@lubber-de

This comment was marked as spam.

@y0hami
Copy link
Member

y0hami commented Nov 10, 2018

@lubber-de I just checked again and I see it now 🤔

@lubber-de

This comment was marked as spam.

@5t4r8ucK
Copy link
Author

5t4r8ucK commented Nov 12, 2018

Ah I forgot one more thing - the reason for the 'will-change'. If the animated buttons are disabled and that property is not set to 'contents' then the text in the disabled animated buttons disappears. Also the animation still doesn't show up in the disabled buttons if tabbed to even with that setting on. I added that example to the jfiddle so this is a new link (and changed the z-index to auto):
https://jsfiddle.net/St4r8ucK/cr4qwm29/15/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants