Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Build Tools] Update RegExps in packaging for npm. #2816

Merged
merged 1 commit into from Aug 10, 2015

Conversation

@davide
Copy link
Contributor

commented Aug 9, 2015

Fixes npm packaging for components api, site (#1878) and transition.

This patch is re-implementation of fixes done in pull request 1156 (#1156) following some concerns raised in #1878.

Update RegExps in packaging for npm.
Fixes npm packaging for components api, site (#1878) and transition.
@jlukic

This comment has been minimized.

Copy link
Member

commented Aug 9, 2015

What modules have you checked the modification against?

I know specifically some modules use a different syntax for extending jquery which could have issues with the regex

@jlukic jlukic added the Confirmed Bug label Aug 9, 2015

@jlukic jlukic added this to the 2.1 milestone Aug 9, 2015

@davide

This comment has been minimized.

Copy link
Contributor Author

commented Aug 10, 2015

I went through all repos (generated by gulp release) that had an index.js file in there, comparing the files before and after the regex replacements.
The new RegExp/replacement retains whatever assignment is already in place (which was the case in the site and api modules):

$.api = $.fn.api = function(parameters) {

turns into:

var _module = module;
$.api = module.exports = function(parameters) {

jlukic added a commit that referenced this pull request Aug 10, 2015

Merge pull request #2816 from davide/next
Update RegExps in packaging for npm.

@jlukic jlukic merged commit cda2650 into Semantic-Org:next Aug 10, 2015

@jlukic jlukic modified the milestones: 2.0.8, 2.1 Aug 10, 2015

@jlukic

This comment has been minimized.

Copy link
Member

commented Aug 10, 2015

I'll release a patch tomorrow

jlukic added a commit that referenced this pull request Aug 10, 2015

jlukic added a commit that referenced this pull request Aug 10, 2015

@jlukic

This comment has been minimized.

Copy link
Member

commented Aug 10, 2015

@davide Do you think it makes sense to leave UI-Transition out of dependencies since this is not actually required by each modules' index.js, or should it be left in?

@jlukic

This comment has been minimized.

Copy link
Member

commented Aug 10, 2015

Tagging on npm as we speak, let me know if that resolves issues.

@jlukic jlukic changed the title Update RegExps in packaging for npm. [Build Tools] Update RegExps in packaging for npm. Aug 12, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.