Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove right icon margin #2973

Closed
wants to merge 1 commit into from
Closed

Remove right icon margin #2973

wants to merge 1 commit into from

Conversation

icharlie
Copy link

@icharlie icharlie commented Sep 7, 2015

right icon margin

http://jsfiddle.net/icharlie/2kduqf0n/1/

rightIconMargin causes there is a little space on the right side.

@jlukic jlukic added this to the 2.1.4 milestone Sep 8, 2015
@jlukic
Copy link
Member

jlukic commented Sep 13, 2015

That margin is because icons with right in the name, right icon, right chevron normally appear on the other side of the text. However it shouldnt be affected labeled icon button.

@jlukic
Copy link
Member

jlukic commented Sep 13, 2015

Added as a different solve.

@icharlie
Copy link
Author

Just in case, the margin I deleted is in the i's right icon inside the button not the labeled icon button.

This change will not affect labeled icon button's style.

@jlukic
Copy link
Member

jlukic commented Sep 13, 2015

It does, the margin is on the .labeled.icon > .button

@icharlie
Copy link
Author

The code I removed is following

-.ui.button > .right.icon:not(.button) {
-  margin: @rightIconMargin;
-}

I am not sure the issue you mentioned.
Can you give me your example?

Sorry for your inconvenience.

@jlukic
Copy link
Member

jlukic commented Sep 13, 2015

You can see this fiddle from next. This solves both the case of a right arrow button with and without labeled icon. The fix you provided would break the second case.
http://jsfiddle.net/88rf4ppd/

@icharlie
Copy link
Author

Should the second case look like?

Okay, I got it. Thank you!

@icharlie
Copy link
Author

Maybe, this should be in the docs as an example!?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants