[Dropdown] Removed deletion of text/value metadata #3879

Closed
wants to merge 1 commit into
from

Projects

None yet

2 participants

@mdehoog
Contributor
mdehoog commented Mar 28, 2016

Fixes #3622.

Happy to put this behind a flag instead if you think the current behavior should be the default.

@jlukic jlukic added a commit that referenced this pull request May 15, 2016
@jlukic jlukic Fixes #3879, #3622 - mutation observers occur erroneously with intern…
…al updates, causing issues
6562429
@jlukic
Member
jlukic commented May 15, 2016

It looks like the internal issue was that mutation observers were accidentally triggering refresh during internal updates to addition or message.

I've resolved this by refactoring the mutation observers to ignore internal changes.

The reason we have to flush data attributes in refresh is that otherwise updating data-value (attribute data values) will not trigger the underlying .data('value') call to update.

These values are typically updated when a mutation observer detects the underlying DOM has been rewritten.

@jlukic jlukic added a commit that referenced this pull request May 15, 2016
@jlukic jlukic Fix debug msg position #3879 ad9ccbf
@jlukic
Member
jlukic commented May 15, 2016

Fixed in 2.2

@jlukic jlukic closed this May 15, 2016
@jlukic jlukic added a commit that referenced this pull request May 15, 2016
@jlukic jlukic Rlsnotes #3879 179ad3d
@mdehoog
Contributor
mdehoog commented May 16, 2016

@jlukic thanks so much for following this up 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment