FIX: auto install did not copy build during npm install #4430

Merged
merged 3 commits into from Dec 21, 2016

Projects

None yet

6 participants

@AnsonT
Contributor
AnsonT commented Aug 12, 2016 edited

With 'autoInstall: true' in semantic.json, npm install does not copy out the semantic files to root directory.

The following check always fails when install.shouldAutoInstall() === true

 /*--------------
    NPM Install
  ---------------*/

  // Check if PM install
  if(answers.useRoot || answers.customRoot) {
@AnsonT
Contributor
AnsonT commented Aug 12, 2016

More testing needed.

@AnsonT AnsonT closed this Aug 12, 2016
@jlukic
Member
jlukic commented Aug 15, 2016 edited

Can you elaborate on what's going on here. The purpose of this fix, what's behaving abnormally about autoInstall.

@AnsonT
Contributor
AnsonT commented Aug 15, 2016

When auto Install is true, npm install does not copy out the files to the base directory (E.g. semantic/) and call gulp build. These changes builds the base directory specified in semantic.json and calls gulp build. I closed the PR for now to do more testing because I realised that I haven't tested all the semantic.json options.

@Milewski

but... it is not copying over..... my wonderful CI ... broken into pieces because of the semantic-ui step... when will this be fixed?

@lindblad

My wonderful Strider CI is broken too :(

@AnsonT
Contributor
AnsonT commented Sep 19, 2016

Added 'build' option in semantic.json to control whether gulp build is ran after autoinstall

@AnsonT AnsonT reopened this Sep 19, 2016
@mdeboer
mdeboer commented Oct 12, 2016

👍 without these proposed fixes autoInstall is broken and will not copy the files. Please merge this ASAP.

@khalwat
khalwat commented Dec 21, 2016

Please fix this... it's broken on our DeployBot setup due to being unable to install via autoInstall

@jlukic
Member
jlukic commented Dec 21, 2016 edited

I've somehow lost track on this issue. I blame this.

I'll issue a patch release, hold on a sec.

@jlukic jlukic merged commit 301b3ad into Semantic-Org:master Dec 21, 2016
@jlukic
Member
jlukic commented Dec 21, 2016

This causes my install to fail with

 TypeError: Path must be a string. Received undefined
    at assertPath (path.js:7:11)
    at Object.join (path.js:1211:7)
    at Gulp.<anonymous> (/home/jack/semantic/ui/tasks/install.js:277:26)
    at module.exports (/home/jack/semantic/ui/node_modules/orchestrator/lib/runTask.js:34:7)
    at Gulp.Orchestrator._runTask (/home/jack/semantic/ui/node_modules/orchestrator/index.js:273:3)
    at Gulp.Orchestrator._runStep (/home/jack/semantic/ui/node_modules/orchestrator/index.js:214:10)
    at Gulp.Orchestrator.start (/home/jack/semantic/ui/node_modules/orchestrator/index.js:134:8)
    at runNextSet (/home/jack/semantic/ui/node_modules/run-sequence/index.js:86:16)
    at Gulp.onTaskEnd (/home/jack/semantic/ui/node_modules/run-sequence/index.js:75:5)
    at emitOne (events.js:101:20)

Currently debugging

@jlukic
Member
jlukic commented Dec 21, 2016 edited

I've modified the install script to avoid the copying when running from git clone 7afba22 (case where manager is undefined)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment