Skip to content

Conversation

@thomas-topway-it
Copy link
Contributor

  • add limit, offset to articlesInCategories
  • add class aliases to support deprecated MW classes (like Title and Categories) with backward compatibility

@codecov
Copy link

codecov bot commented Apr 14, 2025

Codecov Report

Attention: Patch coverage is 3.12500% with 31 lines in your changes missing coverage. Please review.

Project coverage is 14.47%. Comparing base (4a9c287) to head (0d3e830).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
includes/KnowledgeGraph.php 0.00% 18 Missing ⚠️
includes/api/KnowledgeGraphApiLoadCategories.php 0.00% 6 Missing ⚠️
includes/api/KnowledgeGraphApiLoadProperties.php 0.00% 5 Missing ⚠️
includes/aliases/Title.php 0.00% 1 Missing ⚠️
includes/api/KnowledgeGraphApiLoadNodes.php 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main      #13      +/-   ##
============================================
- Coverage     14.82%   14.47%   -0.36%     
  Complexity      114      114              
============================================
  Files             5        6       +1     
  Lines           452      463      +11     
============================================
  Hits             67       67              
- Misses          385      396      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gesinn-it-gea
Copy link
Member

@thomas-topway-it thanks again for working on this extension. I saw this PR. What was the issue for it? Should it be merged?

@thomas-topway-it
Copy link
Contributor Author

@gesinn-it-gea Alexander, the pull request adds limit and offset to search articles by categories, plus support to MW 1.44 where some alias will be removed.
If you don't have specific remarks I will merge it

@gesinn-it-gea
Copy link
Member

... sounds good!

@thomas-topway-it thomas-topway-it merged commit ba47cbc into SemanticMediaWiki:main Apr 24, 2025
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants