Skip to content
This repository has been archived by the owner on Mar 25, 2019. It is now read-only.

Merge old PRs #2

Closed
2 tasks done
PeterTheOne opened this issue Feb 9, 2018 · 10 comments
Closed
2 tasks done

Merge old PRs #2

PeterTheOne opened this issue Feb 9, 2018 · 10 comments
Assignees

Comments

@mwjames
Copy link

mwjames commented Feb 10, 2018

So you cherry pick them and repost them to this repository, I guess, or?

@kghbln
Copy link
Member

kghbln commented Feb 10, 2018

wikimedia/mediawiki-extensions-SemanticComments#1
wikimedia/mediawiki-extensions-SemanticComments#2

I believe that we well all do us a favour if these commiats are being tagged as 2.0.0 Currently there are several versions around calling themselves 1.0. Thus things will be finally identifiably. At the same time SC should start adopting semver. That's why I wrote 2.0.0 instead of 2.0

@kghbln
Copy link
Member

kghbln commented Feb 10, 2018

@PeterTheOne FYI

@PeterTheOne
Copy link
Member Author

@kghbln PRs are "moved". Old Repository can be closed.

@kghbln
Copy link
Member

kghbln commented Feb 12, 2018

@PeterTheOne Thanks for the note. You should be able to merge yourself.

@kghbln
Copy link
Member

kghbln commented Feb 12, 2018

@PeterTheOne Will be there a designated tag for MW 1.27 or will the fix for PHP 7 and MW 1.31 also work for MW 1.27?

@PeterTheOne
Copy link
Member Author

PeterTheOne commented Feb 12, 2018

It should with MW 1.27, the first part of the PR was a fix I did for 1.27 in October. Now I tested and fixed for MW 1.31 and PHP 7

@kghbln
Copy link
Member

kghbln commented Feb 12, 2018

Thanks for the info!

@PeterTheOne
Copy link
Member Author

Testing with travis on multiple versions would be nice ^^

@kghbln
Copy link
Member

kghbln commented Feb 12, 2018

Testing with travis on multiple versions would be nice ^^

Indeed. I'd say go for it. :) Worth to open an issue about it in any case.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants