Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When mainlabel specified an extra mainlabel parameter is added in the further results link #249

Closed
JeroenDeDauw opened this issue Mar 28, 2014 · 3 comments
Labels
bug Occurrence of an unintended or unanticipated behaviour that causes a vulnerability or fatal error

Comments

@JeroenDeDauw
Copy link
Member

Import from https://bugzilla.wikimedia.org/show_bug.cgi?id=34749

SMW 1.7.0.0.2 MW 1.18

This query:

{{#ask: [[Anything]]
| mainlabel=Anymainlabel
}}

Will be changed to this query, when clicking on "further results":

{{#ask: [[Anything]]
| mainlabel=Anymainlabel
| ?=Anymainlabel#
}}

Notice that this part is added by the further results URL query string:

?=Anymainlabel#

The relevant further results url query string is:

/Special:Ask/-5B-5BAnything-5D-5D/-3F%3DAnymainlabel-23/mainlabel%3DAnymainlabel/

When it should be:

/Special:Ask/-5B-5BAnything-5D-5D/mainlabel%3DAnymainlabel/

Note that the query string is produced correctly if it starts out as it would otherwise be incorrectly done. This:

{{#ask: [[Anything]]
| mainlabel=Anymainlabel
| ?=Anymainlabel#
}}

Will produce this:

/Special:Ask/-5B-5BAnything-5D-5D/-3F%3DAnymainlabel-23/mainlabel%3DAnymainlabel/

Just like it should.

This bug is all that look similar when I searched prior to entering this bug. It might be somehow related:

https://bugzilla.wikimedia.org/show_bug.cgi?id=23722

-- badon 2012-02-27 03:48:31 UTC

@JeroenDeDauw
Copy link
Member Author

I can confirm that it is still present in 1.9.0.1.

-- tarkis13@hotmail.com 2014-01-16 17:09:41 UTC

@mwjames
Copy link
Contributor

mwjames commented Mar 12, 2016

@kghbln Is this solved by #541?

@kghbln
Copy link
Member

kghbln commented Mar 13, 2016

Affirmative as the field test shows. Thanks!

@kghbln kghbln closed this as completed Mar 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Occurrence of an unintended or unanticipated behaviour that causes a vulnerability or fatal error
Projects
None yet
Development

No branches or pull requests

3 participants