New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make failed queries discoverable #1243

Merged
merged 1 commit into from Nov 1, 2015

Conversation

Projects
None yet
3 participants
@mwjames
Contributor

mwjames commented Nov 1, 2015

Add a _ERRP annotation for queries with errors to make them discoverable
using the [[Has improper value for::Has query]] property list.

refs #893

Make failed queries discoverable
Add a `_ERRP` annotation for queries with errors to make them discoverable
using the "[[Has improper value for::Has query]]" property list.

@mwjames mwjames added the enhancement label Nov 1, 2015

@mwjames mwjames added this to the SMW 2.4 milestone Nov 1, 2015

mwjames added a commit that referenced this pull request Nov 1, 2015

@mwjames mwjames merged commit 5c5ddba into master Nov 1, 2015

2 of 3 checks passed

Scrutinizer Errored
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@mwjames mwjames deleted the query-error branch Nov 1, 2015

@mwjames

This comment has been minimized.

Contributor

mwjames commented Dec 5, 2015

@kghbln @thingles For the curious mind, this is why wikiapiary's error rate went up (3786).

@kghbln

This comment has been minimized.

Member

kghbln commented Dec 5, 2015

Oops, did not realise this yet. Error count still on the rise. Now I have to figure out which one of the numerous queries is causing this. :| Only wiki-site wikis seem to be concerned ...

@jthingelstad

This comment has been minimized.

Contributor

jthingelstad commented Dec 7, 2015

And continues to, wow…

screenshot

I made a failed queries page but I don't think I understand how to use this feature. When I click on the pages referenced and inspect the queries in the property browser I don't see any errors highlighted.

@mwjames

This comment has been minimized.

Contributor

mwjames commented Dec 7, 2015

When I click on the pages referenced and inspect the queries in the property browser I don't see any errors highlighted.

If you pick one

image

then one query, contains an error

image

It doesn't tell which query because it could be one in the page or an imported one from a template/transclusion.

All we know is that a query failed.

@jthingelstad

This comment has been minimized.

Contributor

jthingelstad commented Dec 7, 2015

@mwjames Got it. Thanks. I was thinking I would then see some sort of an error message attached to one of those subobjects (which would be incredible if it did btw. :-P)

Sure wish there was a "group by" and "count" method for queries so you could show the pages that have the most errors.

WikiApiary has a couple of parser function errors that throw thousands of SMW errors. Notably the one that does database version parsing. But this is showing some additional errors I wasn't aware of. Probably time to spend hours in a text editor matching curly's. :-(

@mwjames

This comment has been minimized.

Contributor

mwjames commented Dec 7, 2015

of an error message attached to one of those subobjects (which would be incredible if it did btw. :-P)

You should see something like [0].

[0] http://sandbox.semantic-mediawiki.org/wiki/Issue/1243_%28Make_failed_queries_discoverable%29

@jthingelstad

This comment has been minimized.

Contributor

jthingelstad commented Dec 7, 2015

@jthingelstad

This comment has been minimized.

Contributor

jthingelstad commented Dec 7, 2015

It's interesting to me that the failed queries that have a property other than "Has query" when I look at the page I can find the yellow "!" notice that is associated with the error. The vast majority of these though just say "Has query" and when I look at the page there is no user visible error message.

@mwjames

This comment has been minimized.

Contributor

mwjames commented Dec 7, 2015

The vast majority of these though just say "Has query" and when I look at the page there is no user visible error message.

The error property is just a "plain" page property therefore it can only link to the property where the condition of an error has been identified. Of course you can ignore it but the system just makes things visible that otherwise stay hidden.

With the statistics above, I'm guessing it is one particular query that comes with a template and is embedded in all pages (and slowly grows as the bot makes it way though the pages).

@jthingelstad

This comment has been minimized.

Contributor

jthingelstad commented Dec 7, 2015

@mwjames fwiw, and maybe it isn't possible, but if you attached the 'text' property for the error message into that subobject it would be huge huge huge. Possible?

@mwjames

This comment has been minimized.

Contributor

mwjames commented Dec 7, 2015

nd maybe it isn't possible, but if you attached the 'text' property for the error message it would be huge huge huge. Possible?

Not in the way the _ERRP (== Has improper value for, it is just a _wpg object) is specified, you have to turn this into a subobject itself in order to attach additional information (conceptional it is a different entity representing different information relating to a subject)

Possible?

You mean something like #1293?

image

mwjames added a commit that referenced this pull request Dec 7, 2015

Merge pull request #1293 from SemanticMediaWiki/errc
Add _ERRC (container to store erroneous annotation), refs #1243
@jthingelstad

This comment has been minimized.

Contributor

jthingelstad commented Dec 8, 2015

@mwjames that is incredible! Seriously! Huge huge. Actually big enough for me to risk the composer update. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment