New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Isolate part of the SMWQueryParser #1291

Merged
merged 1 commit into from Dec 6, 2015

Conversation

Projects
None yet
2 participants
@mwjames
Contributor

mwjames commented Dec 5, 2015

Move some parts from SMWQueryParser into SMW\Query\Parser\DescriptionProcessor to allow for refactoring of the QueryParser to only handle string manipulation and syntax logic.

Add support for range queries as in [[>Example/0608-A]] [[<Example/0608-C]] (or
[>Example/0608-AA]] [[<Example/0608-CCC]]).

{
    "about": "#0 range >A <C (non strict comparator)",
    "condition": "[[Category:Q0610]] [[>Example/Q0610-A]] [[<Example/Q0610-C]]",
    "printouts" : [],
    "parameters" : {
        "limit" : 10
    },
    "queryresult": {
        "count": 3,
        "results": [
            "Example/Q0610-A#0##",
            "Example/Q0610-AAA#0##",
            "Example/Q0610-BBB#0##"
        ]
    }
},
{
    "about": "#1 range >AA <CCC (non strict comparator)",
    "condition": "[[Category:Q0610]] [[>Example/Q0610-AA]] [[<Example/Q0610-CCC]]",
    "printouts" : [],
    "parameters" : {
        "limit" : 10
    },
    "queryresult": {
        "count": 3,
        "results": [
            "Example/Q0610-AAA#0##",
            "Example/Q0610-BBB#0##",
            "Example/Q0610-CCC#0##"
        ]
    }
}

refs #1246

@mwjames mwjames added this to the SMW 2.4 milestone Dec 5, 2015

Isolate part of the SMWQueryParser
Move some parts from `SMWQueryParser` into
`SMW\Query\Parser\DescriptionProcessor` to refactor the
`QueryParser` to only handle string manipulation and syntax
logic.

Add support for range queries as in `[[>Example/0610-A]] [[<Example/0610-C]]` (or
`[>Example/0610-AA]] [[<Example/0610-CCC]]`).

mwjames added a commit that referenced this pull request Dec 6, 2015

Merge pull request #1291 from SemanticMediaWiki/q-parser
Isolate part of the SMWQueryParser

@mwjames mwjames merged commit 86d0b13 into master Dec 6, 2015

3 checks passed

Scrutinizer 10 new issues, 50 updated code elements
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@mwjames mwjames deleted the q-parser branch Dec 6, 2015

@mwjames

This comment has been minimized.

Show comment
Hide comment
@mwjames

mwjames Dec 6, 2015

Contributor

@kghbln FYI

Contributor

mwjames commented Dec 6, 2015

@kghbln FYI

@mwjames

This comment has been minimized.

Show comment
Hide comment
Contributor

mwjames commented Dec 6, 2015

@mwjames

This comment has been minimized.

Show comment
Hide comment
@mwjames

mwjames Dec 6, 2015

Contributor

Moving from F ↗ D for the SMWQueryParser (still not great but better than nothing)

Contributor

mwjames commented Dec 6, 2015

Moving from F ↗ D for the SMWQueryParser (still not great but better than nothing)

mwjames added a commit that referenced this pull request Dec 8, 2015

Merge pull request #1297 from SemanticMediaWiki/q-parser
DescriptionProcessor to always fetch a possible error, refs #1291
@kghbln

This comment has been minimized.

Show comment
Hide comment
@kghbln

kghbln Dec 8, 2015

Member

still not great but better than nothing

No worries since it is an improvement. Thanks! 👍

Member

kghbln commented Dec 8, 2015

still not great but better than nothing

No worries since it is an improvement. Thanks! 👍

@kghbln

This comment has been minimized.

Show comment
Hide comment
@kghbln
Member

kghbln commented Aug 17, 2016

@mwjames mwjames referenced this pull request Oct 15, 2017

Merged

Move SMWQueryParser to SMW\Query\Parser #2774

2 of 2 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment