New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check subobject named identifier #1299

Merged
merged 1 commit into from Dec 9, 2015

Conversation

Projects
None yet
1 participant
@mwjames
Contributor

mwjames commented Dec 9, 2015

Named identifiers containing a dot are reserved for extension use.

{{#subobject:foo.bar
 |foo=bar
}}

@mwjames mwjames added this to the SMW 2.4 milestone Dec 9, 2015

$containerSemanticData = new ContainerSemanticData( $subWikiPage );
// Encode brackets to avoid an annotion is created/included
return $this->newDiContainer( $subject, $property, str_replace( '[', '[', $errorMsg ) );
}

This comment has been minimized.

@mwjames

mwjames Dec 9, 2015

Contributor

@kghbln This fixes [0] where a queried error list copied [[ ... ]] annotations from the query result into a page.

[0] https://wikiapiary.com/wiki/Special:Browse/User:Thingles-2FFailed_queries

Check subobject named identifier
Named identifiers containing a dot are reserved for extension use.

```
{{#subobject:foo.bar
 |foo=bar
}}
```

mwjames added a commit that referenced this pull request Dec 9, 2015

Merge pull request #1299 from SemanticMediaWiki/sobj
Check subobject named identifier

@mwjames mwjames merged commit 1563091 into master Dec 9, 2015

3 checks passed

Scrutinizer 2 new issues, 5 updated code elements
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@mwjames mwjames deleted the sobj branch Dec 9, 2015

mwjames added a commit that referenced this pull request Dec 9, 2015

Merge pull request #1302 from SemanticMediaWiki/sobj
Less restrictive rule for sobj named identifiers, refs #1299
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment