New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rebuildData to output more verbose info, add `--ignore-exceptions`, r… #1433

Merged
merged 1 commit into from Mar 5, 2016

Conversation

Projects
None yet
4 participants
@mwjames
Contributor

mwjames commented Mar 4, 2016

…efs #1327

Output more verbose information about what entity is being rebuild.

  • Add --ignore-exceptions and --redirects option
  • Option --categories is -c

image

ID's marked with * are in reference to the MW page table where the same ID does not necessarily represent the same entity (see 30).

image

@mwjames mwjames added the enhancement label Mar 4, 2016

@mwjames mwjames added this to the SMW 2.4 milestone Mar 4, 2016

@mwjames

This comment has been minimized.

Show comment
Hide comment
@mwjames

mwjames Mar 4, 2016

Contributor

@kghbln OK, I didn't plan on this but --ignore-exceptions was just added (in case of an exception, the file exception-....log [0] will contain that information).

Happy testing!

[0] https://github.com/SemanticMediaWiki/SemanticMediaWiki/pull/1433/files#diff-05d44ea7d2b4980df07a3b7396a34eeeR142

Contributor

mwjames commented Mar 4, 2016

@kghbln OK, I didn't plan on this but --ignore-exceptions was just added (in case of an exception, the file exception-....log [0] will contain that information).

Happy testing!

[0] https://github.com/SemanticMediaWiki/SemanticMediaWiki/pull/1433/files#diff-05d44ea7d2b4980df07a3b7396a34eeeR142

@jamesmontalvo3

This comment has been minimized.

Show comment
Hide comment
@jamesmontalvo3

jamesmontalvo3 Mar 5, 2016

Contributor

This change is phenomenal and I can't thank you enough for it. Looking forward to testing it out. If I'm reading it right it puts the log file in the extensions directory. Any reason that directory was chosen? Mind if I take a stab at changing the --ignore-exceptions option to allow specifying a log file? Would it be better to have yet another option like --exception-log=/some/path or maybe make just the one option?

Contributor

jamesmontalvo3 commented Mar 5, 2016

This change is phenomenal and I can't thank you enough for it. Looking forward to testing it out. If I'm reading it right it puts the log file in the extensions directory. Any reason that directory was chosen? Mind if I take a stab at changing the --ignore-exceptions option to allow specifying a log file? Would it be better to have yet another option like --exception-log=/some/path or maybe make just the one option?

@kghbln

This comment has been minimized.

Show comment
Hide comment
@kghbln

kghbln Mar 5, 2016

Member

This is utterly great. Thanks a ton! It does not relieve admins from tracking down the issues and reporting them but it helps actually getting the task of rebuilding data done as well.

Having the log file in the extensions directory is not ideal especially in farmed environments, so being able to specify a path will be preferable. I do not think an extra option is necessary, so I can imagine

--ignore-exeptions would write to the standard path specified by the script and

--ignore-exeptions=/some/path would allow to specify an alternate path for the log

Not logging exceptions does not make much sense I believe so this option appears not necessary to me.

Having more verbose descriptions is a very nice extra too. Cool!

Member

kghbln commented Mar 5, 2016

This is utterly great. Thanks a ton! It does not relieve admins from tracking down the issues and reporting them but it helps actually getting the task of rebuilding data done as well.

Having the log file in the extensions directory is not ideal especially in farmed environments, so being able to specify a path will be preferable. I do not think an extra option is necessary, so I can imagine

--ignore-exeptions would write to the standard path specified by the script and

--ignore-exeptions=/some/path would allow to specify an alternate path for the log

Not logging exceptions does not make much sense I believe so this option appears not necessary to me.

Having more verbose descriptions is a very nice extra too. Cool!

@mwjames

This comment has been minimized.

Show comment
Hide comment
@mwjames

mwjames Mar 5, 2016

Contributor

Having the log file in the extensions directory is not ideal especially in farmed environments, so being able to specify a path will be preferable.

I'd go for the --exception-log=/some/path option, as the connotation of --ignore-exeptions is a either or decision (== boolean) which in case of a true could imply an additional information but I'd rather split them.

Contributor

mwjames commented Mar 5, 2016

Having the log file in the extensions directory is not ideal especially in farmed environments, so being able to specify a path will be preferable.

I'd go for the --exception-log=/some/path option, as the connotation of --ignore-exeptions is a either or decision (== boolean) which in case of a true could imply an additional information but I'd rather split them.

@kghbln

This comment has been minimized.

Show comment
Hide comment
@kghbln

kghbln Mar 5, 2016

Member

I'd go for the --exception-log=/some/path option ... but I'd rather split them.

You have a point here. That's fine with me too.

Member

kghbln commented Mar 5, 2016

I'd go for the --exception-log=/some/path option ... but I'd rather split them.

You have a point here. That's fine with me too.

rebuildData to output more verbose info, add `--ignore-exceptions`, r…
…efs 1327

Output more verbose information about what entiyt is being rebuild.

- Add `--ignore-exceptions` and `--redirects` option
- Add `--exception-log` to specify a location otherwise the SMW root diretory is used
- Option `--categories` is `-c`
@mwjames

This comment has been minimized.

Show comment
Hide comment
@mwjames

mwjames Mar 5, 2016

Contributor

I'd go for the --exception-log=/some/path option

... and so it is done php maintenance/rebuildData.php -v --ignore-exceptions --exception-log="/D/xampp/tmp/logs/"

Contributor

mwjames commented Mar 5, 2016

I'd go for the --exception-log=/some/path option

... and so it is done php maintenance/rebuildData.php -v --ignore-exceptions --exception-log="/D/xampp/tmp/logs/"

mwjames added a commit that referenced this pull request Mar 5, 2016

Merge pull request #1433 from SemanticMediaWiki/rebuild
rebuildData to output more verbose info, add `--ignore-exceptions`, r…

@mwjames mwjames merged commit 0545053 into master Mar 5, 2016

3 checks passed

Scrutinizer 11 new issues, 45 updated code elements
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@mwjames mwjames deleted the rebuild branch Mar 5, 2016

@kimcollin

This comment has been minimized.

Show comment
Hide comment
@kimcollin

kimcollin Mar 11, 2016

Glad u liked it

On Friday, 4 March 2016, James Montalvo notifications@github.com wrote:

This change is phenomenal and I can't thank you enough for it. Looking
forward to testing it out. If I'm reading it right it puts the log file in
the extensions directory. Any reason that directory was chosen? Mind if I
take a stab at changing the --ignore-exceptions option to allow
specifying a log file? Would it be better to have yet another option like
--exception-log=/some/path or maybe make just the one option?


Reply to this email directly or view it on GitHub
#1433 (comment)
.

Kimberly collins

kimcollin commented Mar 11, 2016

Glad u liked it

On Friday, 4 March 2016, James Montalvo notifications@github.com wrote:

This change is phenomenal and I can't thank you enough for it. Looking
forward to testing it out. If I'm reading it right it puts the log file in
the extensions directory. Any reason that directory was chosen? Mind if I
take a stab at changing the --ignore-exceptions option to allow
specifying a log file? Would it be better to have yet another option like
--exception-log=/some/path or maybe make just the one option?


Reply to this email directly or view it on GitHub
#1433 (comment)
.

Kimberly collins

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment