New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PostgreSQL support #1610

Merged
merged 1 commit into from May 25, 2016

Conversation

Projects
None yet
3 participants
@vitalif

vitalif commented May 24, 2016

Without this commit, SMW with pgsql results in:

Notice: pg_send_query(): There are results on this connection. Call pg_get_result() until it returns FALSE in ./includes/db/DatabasePostgres.php on line 490

and then

RuntimeException from line 181 of ./extensions/SemanticMediaWiki/src/MediaWiki/Database.php: Unable to post new query to PostgreSQL

Also using anonymous DO block does not pollute pg_temp with stored procedures and is shorter.

Vitaliy Filippov
Fix PostgreSQL support
Without this commit, SMW with pgsql results in:

Notice: pg_send_query(): There are results on this connection. Call pg_get_result() until it returns FALSE in ./includes/db/DatabasePostgres.php on line 490

and then

RuntimeException from line 181 of ./extensions/SemanticMediaWiki/src/MediaWiki/Database.php: Unable to post new query to PostgreSQL

Also using anonymous DO block does not pollute pg_temp with stored procedures and is shorter.

vitalif referenced this pull request in mediawiki4intranet/SemanticMediaWiki May 24, 2016

Vitaliy Filippov
Patch: fix-pgsql
Type: bugfix

Fix PostgreSQL support
@JeroenDeDauw

This comment has been minimized.

Member

JeroenDeDauw commented May 24, 2016

Thank you for contributing

@mwjames mwjames merged commit da28400 into SemanticMediaWiki:master May 25, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@vitalif

This comment has been minimized.

vitalif commented May 25, 2016

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment