New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add query parameters to profile #2270

Merged
merged 1 commit into from Feb 18, 2017

Conversation

Projects
None yet
2 participants
@mwjames
Contributor

mwjames commented Feb 18, 2017

This PR is made in reference to: #

This PR addresses or contains:

  • Add ability to record query parameters, this would subsequently enable SMW to recreate query results using a background job

This PR includes:

  • Tests (unit/integration)
  • CI build passed

@mwjames mwjames added the enhancement label Feb 18, 2017

@mwjames mwjames added this to the SMW 2.5.0 milestone Feb 18, 2017

@mwjames

This comment has been minimized.

Contributor

mwjames commented Feb 18, 2017

Without knowing the parameters, running queries independent of the MW parser is not possible because sorting and limit directly influence on how and which results are fetched from the backend, but by recording those it will enable SMW to run a background job (which is not part of this PR) without the need to parse a page in order to recreate the Query/Description object.

image

@mwjames mwjames merged commit da92b91 into master Feb 18, 2017

3 checks passed

Scrutinizer 4 new issues, 12 updated code elements
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@mwjames mwjames deleted the profile-params branch Feb 18, 2017

@kghbln

This comment has been minimized.

Member

kghbln commented Feb 19, 2017

This one requires to run "setupStore.php" even if $smwgQueryProfiler is not enabled for duration and parameters so ...

Checking table smw_fpt_askpa ...
   Table not found, now creating...
   ... done.

@kghbln kghbln referenced this pull request Feb 20, 2017

Merged

Update de.json #2277

1 of 2 tasks complete
@kghbln

This comment has been minimized.

Member

kghbln commented Feb 27, 2017

@mwjames I have just enabled query profiling for duration and parameters. However parameters do not seem to get through like for the query on this page.

@kghbln

This comment has been minimized.

Member

kghbln commented Feb 28, 2017

@kghbln

This comment has been minimized.

Member

kghbln commented Mar 4, 2017

@mwjames Hmm, even after rebuilding data nothing shows up for this special property. Is there a trick or an issue?

@mwjames

This comment has been minimized.

Contributor

mwjames commented Mar 4, 2017

Hmm, even after rebuilding data nothing shows up for this special property. Is there a trick or an issue?

I know, I have to make a small adjustment. A PR is coming in soon ... stay tuned.

@kghbln

This comment has been minimized.

Member

kghbln commented Mar 4, 2017

A PR is coming in soon ... stay tuned.

Ah, no worries.

@mwjames mwjames referenced this pull request Mar 5, 2017

Merged

Follow-up on query parameters, refs 2270 #2305

2 of 2 tasks complete
@mwjames

This comment has been minimized.

Contributor

mwjames commented Mar 5, 2017

Hmm, even after rebuilding data nothing shows up for this special property. Is there a trick or an issue?

This PR was missing an integration test and with it a misinterpretation of a setting which has now been addressed in #2305.

mwjames added a commit that referenced this pull request Mar 5, 2017

@kghbln

This comment has been minimized.

Member

kghbln commented Mar 5, 2017

This PR was missing an integration test and with it a misinterpretation of a setting which has now been addressed in #2305.

Great! Now working cool!

@mwjames mwjames referenced this pull request Sep 16, 2017

Merged

Add query scode to profile, refs 2270, 2572 #2673

2 of 2 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment