Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IdTaskHandler to allow string match for ID #2324

Merged
merged 1 commit into from Mar 11, 2017

Conversation

Projects
None yet
2 participants
@mwjames
Copy link
Contributor

mwjames commented Mar 11, 2017

This PR is made in reference to: #2268

This PR addresses or contains:

  • Allows for the ID to be a string to filter on the sortkey and return pairs of matches

This PR includes:

  • Tests (unit/integration)
  • CI build passed

@mwjames mwjames added this to the SMW 2.5.0 milestone Mar 11, 2017

@mwjames mwjames merged commit 089e57f into master Mar 11, 2017

3 checks passed

Scrutinizer 1 new issues, 2 updated code elements
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@mwjames mwjames deleted the rc1-id-task branch Mar 11, 2017

@mwjames

This comment has been minimized.

Copy link
Contributor Author

mwjames commented Mar 11, 2017

@kghbln FYI I wanted to investigate something on semantic-mediawiki.org but realized that Object ID lookup and disposal can only work with numeric IDs. I tweaked the input a bit with this PR so that now one can also use a string to find matching IDs and work its way through.

For example, sandbox.semantic-mediawiki.org with input P106 returns:

image

If the results are not unique (as in case for a single dedicated ID) then the form fields will remove any input hint.

@kghbln

This comment has been minimized.

Copy link
Member

kghbln commented Mar 11, 2017

Very nice improvement!

@mwjames mwjames referenced this pull request Aug 19, 2017

Merged

Ren IdTaskHandler, refs 2324 #2630

1 of 2 tasks complete

mwjames added a commit that referenced this pull request Nov 11, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.