Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NamespaceManager avoid reset of user settings, refs 2439 #2444

Merged
merged 1 commit into from May 6, 2017

Conversation

Projects
None yet
2 participants
@mwjames
Copy link
Contributor

mwjames commented May 6, 2017

This PR is made in reference to: #2439

This PR addresses or contains:

This PR includes:

  • Tests (unit/integration)
  • CI build passed
@mwjames

This comment has been minimized.

Copy link
Contributor Author

mwjames commented May 6, 2017

@kghbln FYI

@kghbln kghbln added this to the SMW 2.5.2 milestone May 6, 2017

@mwjames mwjames merged commit 8878300 into master May 6, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@mwjames mwjames deleted the ns branch May 6, 2017

@mwjames

This comment has been minimized.

Copy link
Contributor Author

mwjames commented May 6, 2017

Back-ported to 2.5.x with 8c9c4c3.

@kghbln

This comment has been minimized.

Copy link
Member

kghbln commented May 6, 2017

@mwjames Hmm ... there is still something in the water. I have added

$wgNamespacesToBeSearchedDefault = [
        NS_MAIN => true,
        NS_FILE => true,
	SMW_NS_PROPERTY => true
        ];

to "LocalSettings.php" for sandbox but now neither Property nor Concept are searched by default.

@mwjames

This comment has been minimized.

Copy link
Contributor Author

mwjames commented May 6, 2017

there is still something in the water. I have added

image

Are you sure because my local test showed the opposite. The change was made so that any setting that exists are not overridden and in case they don't exists are added with a true value.

You can check the setting by adding var_dump( $wgNamespacesToBeSearchedDefault ) to [0].

[0] https://github.com/wikimedia/mediawiki/blob/c64e2b3fede0d7793cfefa0ff67f2ddad67febd9/includes/user/User.php#L1563-L1595

@kghbln

This comment has been minimized.

Copy link
Member

kghbln commented May 6, 2017

Ah, oops indeed. Now it is also working in sandbox. Probably the change still somehow had to propagate through caching etc. Sorry for the noise!

@kghbln

This comment has been minimized.

Copy link
Member

kghbln commented May 10, 2017

I may note that $wgNamespacesToBeSearchedDefault must be done after the inclusion of SMW as far as semantic namespaces are concerned. Otherwise one will get as to be expected the following PHP notices:

Notice: Use of undefined constant SMW_NS_PROPERTY - assumed 'SMW_NS_PROPERTY' in /w/LocalSettings.php on line xxx
Notice: Use of undefined constant SMW_NS_CONCEPT - assumed 'SMW_NS_CONCEPT' in /w/LocalSettings.php on line xxx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.