Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Construct this.date after determining components #2451
This PR includes:
Prior to this commit, this.date was constructed with just the year and then used setXYZ() methods (e.g. setMonth(), setDate()) to update the date as required based upon other values. This was causing bad dates as noticed in SemanticResultFormats
referenced this pull request
May 8, 2017
I'd appreciated if you could replace the date getter methods with their UTC equivalent (as noted on the other thread) now that `Date.UTC` is explicitly used. PS: I'm only doing weekend sprints (incl. merge windows) but anyone else is free to do a merge if it is really urgent. Cheers…
Thanks for the confirmation.
I'm glad that we found a solution with the help of the various parties involved especially given that issue presented or better shrouded itself obscure under certain conditions.