Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Count and limit expensive #ask/#show functions, refs 2469 #2476

Merged
merged 1 commit into from Jun 10, 2017

Conversation

@mwjames
Copy link
Contributor

commented May 21, 2017

This PR is made in reference to: #2469

This PR addresses or contains:

  • $smwgQExpensiveThreshold (Threshold in seconds that define an expensive #ask/#show function) and
  • $smwgQExpensiveExecutionLimit (Limit of expensive #ask/#show functions)
  • It counts all expensive functions (as per definition) and cut-off any #ask/#show that follows the reached limit in a semi sequential process with the exception that a #ask/#show (limit=0) can still be executed even though the counter has reached the limit. In case of $smwgQExpensiveThreshold=0 any #ask/#show will be counted towards the limit.
  • The limit is disabled by default.

This PR includes:

  • Tests (unit/integration)
  • CI build passed
@mwjames mwjames added this to the SMW 3.0.0 milestone May 21, 2017
@mwjames mwjames added the feature label May 21, 2017
@mwjames

This comment has been minimized.

Copy link
Contributor Author

commented May 21, 2017

image

@mwjames mwjames added this to In process in Enhancements and features May 28, 2017
@mwjames mwjames force-pushed the expensive branch from 8cce2b4 to 9520cca Jun 10, 2017
@mwjames mwjames merged commit f98db6a into master Jun 10, 2017
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@mwjames mwjames deleted the expensive branch Jun 10, 2017
@mwjames mwjames moved this from In progress to Resolved in Enhancements and features Jun 10, 2017
@mwjames mwjames referenced this pull request Sep 23, 2017
2 of 2 tasks complete
@mwjames mwjames removed this from Resolved in Enhancements and features Oct 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.