Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HtmlValidator check for CssSelectorConverter #2563

Merged
merged 1 commit into from Jul 23, 2017

Conversation

Projects
None yet
2 participants
@mwjames
Copy link
Contributor

mwjames commented Jul 23, 2017

This PR is made in reference to: #2540

This PR addresses or contains:

Avoids things like "Error: Class 'Symfony\Component\CssSelector\CssSelectorConverter' not found" where the dependency isn't available.

1) SMW\Tests\Integration\JSONScript\JsonTestCaseScriptRunnerTest::executeTestCases with data set "f-0401.json" ('...\exte...1.json')
Error: Class 'Symfony\Component\CssSelector\CssSelectorConverter' not found

...\extensions\SemanticMediaWiki\tests\phpunit\Utils\Validators\HtmlValidator.php:80
...\extensions\SemanticMediaWiki\tests\phpunit\Integration\JSONScript\ParserHtmlTestCaseProcessor.php:76
...\extensions\SemanticMediaWiki\tests\phpunit\Integration\JSONScript\ParserHtmlTestCaseProcessor.php:51
...\extensions\SemanticMediaWiki\tests\phpunit\Integration\JSONScript\JsonTestCaseScriptRunnerTest.php:407
...\extensions\SemanticMediaWiki\tests\phpunit\Integration\JSONScript\JsonTestCaseScriptRunnerTest.php:171
...\extensions\SemanticMediaWiki\tests\phpunit\JsonTestCaseScriptRunner.php:179
...\extensions\SemanticMediaWiki\tests\phpunit\MwDBaseUnitTestCase.php:131
...\maintenance\doMaintenance.php:111

This PR includes:

  • Tests (unit/integration)
  • CI build passed

@mwjames mwjames merged commit ce4c6e8 into master Jul 23, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@mwjames mwjames deleted the html-val branch Jul 23, 2017

mwjames added a commit that referenced this pull request Aug 5, 2017

@kghbln kghbln added this to the SMW 2.5.4 milestone Aug 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.