Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2567: Start template parameters on new line #2568

Merged
merged 2 commits into from Jul 29, 2017

Conversation

Projects
None yet
2 participants
@s7eph4n
Copy link
Contributor

s7eph4n commented Jul 26, 2017

This PR is made in reference to: #2567

This PR addresses or contains:

  • Start each parameter of the template calls created by the template format on a new line

This PR includes:

  • Tests (unit/integration)
  • CI build passed

Fixes #2567

s7eph4n added some commits Jul 26, 2017

@s7eph4n s7eph4n requested a review from mwjames Jul 26, 2017

@mwjames mwjames merged commit b5f559e into master Jul 29, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@mwjames mwjames deleted the fix2567 branch Jul 29, 2017

@mwjames

This comment has been minimized.

Copy link
Contributor

mwjames commented Jul 29, 2017

Nice.

This should also solve {{#set: SomeProperty=SomeValue |template=ValueContainsEqualSign }}.

@mwjames

This comment has been minimized.

Copy link
Contributor

mwjames commented Jul 30, 2017

Back-ported to 2.5.x with c8d6718.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.