Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add create restriction on properties, refs 2232 #2600

Merged
merged 1 commit into from Aug 12, 2017

Conversation

@mwjames
Copy link
Contributor

commented Aug 6, 2017

This PR is made in reference to: #2232

This PR addresses or contains:

  • Adds $smwgCreateProtectionRight setting
  • If enabled, restrict creation of new properties to user with the assigned right only
  • As outcome of the authority mode, typing is enforced for each property that is created or used in an annotation process
  • https://www.semantic-mediawiki.org/wiki/Authority_mode

image

This PR includes:

  • Tests (unit/integration)
  • CI build passed
@mwjames mwjames added the feature label Aug 6, 2017
@mwjames mwjames added this to the SMW 3.0.0 milestone Aug 6, 2017
@mwjames

This comment has been minimized.

Copy link
Contributor Author

commented Aug 6, 2017

@kghbln FYI, I'll leave this open for a week in case you want to comment.

@kghbln

This comment has been minimized.

Copy link
Member

commented Aug 7, 2017

Indeed a nice enhancement which supports data curation and gardening! One question: How does this integrate with special page "WantedProperties" which currently has a slightly different scope? I can imagine that such properties which were not yet created could be listed there too - somehow marked in a special way.

@mwjames mwjames force-pushed the authority-prop branch from fe2aead to f01e7e1 Aug 12, 2017
@mwjames

This comment has been minimized.

Copy link
Contributor Author

commented Aug 12, 2017

integrate with special page "WantedProperties" which currently has a slightly different scope? I can imagine that such properties which were not yet created could be listed there too

I'll try to squeeze in a follow-up on this.

@mwjames mwjames force-pushed the authority-prop branch from f01e7e1 to 6ee27c7 Aug 12, 2017
@mwjames mwjames merged commit 9de468c into master Aug 12, 2017
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@mwjames mwjames deleted the authority-prop branch Aug 12, 2017
@mwjames mwjames referenced this pull request Aug 12, 2017
2 of 2 tasks complete
@mwjames

This comment has been minimized.

Copy link
Contributor Author

commented Aug 12, 2017

I'll try to squeeze in a follow-up on this.

Done in #2615.

@mwjames mwjames referenced this pull request Aug 19, 2017
2 of 2 tasks complete
@mwjames mwjames referenced this pull request Oct 14, 2017
2 of 2 tasks complete
@mwjames mwjames referenced this pull request Nov 11, 2017
2 of 2 tasks complete
@kghbln

This comment has been minimized.

Copy link
Member

commented Nov 26, 2017

@mwjames

This comment has been minimized.

Copy link
Contributor Author

commented Nov 26, 2017

https://www.semantic-mediawiki.org/wiki/Help:Create_protection - to be fluffed

I gave it a quick note.

@kghbln

This comment has been minimized.

Copy link
Member

commented Nov 26, 2017

I gave it a quick note.

Cool, my earlier comment was more of a not to self. Nice. $smwgCreateProtectionRight is documented too. :)

@mwjames

This comment has been minimized.

Copy link
Contributor Author

commented Nov 26, 2017

@kghbln Quick question, Do you think we can make the collection display of the same size as the infobox (280px) since the current box feels a bit overwhelming when reading (focusing on) the text.

@kghbln

This comment has been minimized.

Copy link
Member

commented Nov 26, 2017

Yeah, sure. Since I do not use mobile devices I have no idea how the wiki appears on respective clients. For me personally on a desktop things are already pretty tiny.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.