Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Special:Ask add noscript #2609

Merged
merged 1 commit into from Aug 12, 2017

Conversation

@mwjames
Copy link
Contributor

mwjames commented Aug 12, 2017

This PR is made in reference to: #

This PR addresses or contains:

  • We expect Javascript to be available and enabled for the best possible user experience therefore make any user aware of that fact [0] and soft-disable the display if the requirement is not met.
  • The input display will be disabled until the JS is loaded and only then the visual lock is removed to indicate that the page is ready.

image

[0] https://www.semantic-mediawiki.org/wiki/Noscript

This PR includes:

  • Tests (unit/integration)
  • CI build passed
@mwjames mwjames added this to the SMW 3.0.0 milestone Aug 12, 2017
@mwjames mwjames merged commit a4b8e0f into master Aug 12, 2017
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@mwjames mwjames deleted the ask-noscript branch Aug 12, 2017
@mwjames

This comment has been minimized.

Copy link
Contributor Author

mwjames commented Aug 12, 2017

@kghbln FYI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.