New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Special:Ask add input assistance to condition textarea #2699

Merged
merged 1 commit into from Sep 24, 2017

Conversation

Projects
None yet
2 participants
@mwjames
Copy link
Contributor

mwjames commented Sep 23, 2017

This PR is made in reference to: #2696

This PR addresses or contains:

  • Adds the https://github.com/ichord/At.js plug-in (License: MIT)
  • The plug-in allows us to provide an input assistance for the condition textarea with search support for:
    • p: properties
    • c: categories, and
    • con: concepts

ask-input-assistance

This PR includes:

  • Tests (unit/integration)
  • CI build passed

@mwjames mwjames added the feature label Sep 23, 2017

@mwjames mwjames added this to the SMW 3.0.0 milestone Sep 23, 2017

@mwjames mwjames force-pushed the ask-cond-autocomplete branch from dea99fa to e1b858e Sep 23, 2017

@mwjames mwjames force-pushed the ask-cond-autocomplete branch from e1b858e to 05825bf Sep 24, 2017

@mwjames mwjames merged commit a945401 into master Sep 24, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@mwjames mwjames deleted the ask-cond-autocomplete branch Sep 24, 2017

@mwjames

This comment has been minimized.

Copy link
Contributor

mwjames commented Sep 24, 2017

@kghbln FYI

@@ -884,6 +889,7 @@
'smwgPropertiesCacheExpiry' => 3600,
'smwgStatisticsCache' => true,
'smwgStatisticsCacheExpiry' => 3600,
'api.browse' => 3600
),

This comment has been minimized.

@kghbln

kghbln Sep 24, 2017

Member

@mwjames Cannot this be named somewhat more consistent like e.g. smwgApiBrowse?

This comment has been minimized.

@mwjames

mwjames Sep 30, 2017

Contributor

I'm considering to rename the others because there is some cruft, maybe something like:

  • special.statistics which can be either a number or false and would kill one of the settings
  • special.properties
  • special.unusedproperties
  • special.wantedproperties

This comment has been minimized.

@kghbln

kghbln Sep 30, 2017

Member

Makes sense to me. Also this would indeed make configuration a bit easier. Go for it. :)

mwjames added a commit that referenced this pull request Sep 24, 2017

@kghbln

This comment has been minimized.

Copy link
Member

kghbln commented Sep 30, 2017

Documented here and there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment