Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional checks for enabled namespaces #2773

Merged
merged 1 commit into from Oct 15, 2017

Conversation

Projects
None yet
2 participants
@mwjames
Copy link
Contributor

mwjames commented Oct 14, 2017

This PR is made in reference to: #

This PR addresses or contains:

  • While looking at [0], I found entries like the sample below which should not happen because "smw_namespace": "200" (Print namespace) is disabled for SMW usage
  • This is caused by a page transclusion [1] that hosts embedded queries with the QueryDependencyLinksStore not explicitly checking the context page namespace prior creating an id reference
    "109866": {
        "smw_id": "109866",
        "smw_title": "User_manual",
        "smw_namespace": "200",
        "smw_iw": "",
        "smw_subobject": "_QUERY85faec9baa9a72381449338d9fb87801",
        "smw_sortkey": "User manual"
    },

[0] https://www.semantic-mediawiki.org/w/index.php?title=Special%3ASemanticMediaWiki&action=idlookup&id=&id=User+manual
[1] https://www.semantic-mediawiki.org/wiki/Print:User_manual

This PR includes:

  • Tests (unit/integration)
  • CI build passed

Fixes #

@mwjames

This comment has been minimized.

Copy link
Contributor Author

mwjames commented Oct 14, 2017

@kghbln FYI This maybe worth backporting but it would require a bit more manual testing to avoid a regression since I had to modify the PropertyTableIdReferenceFinder::findAtLeastOneActiveReferenceById method.

@mwjames mwjames merged commit 6f3ba57 into master Oct 15, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@mwjames mwjames deleted the invalid-ns branch Oct 15, 2017

@kghbln

This comment has been minimized.

Copy link
Member

kghbln commented Oct 16, 2017

I switched smw.o to "2.5.x@dev" so a backport could more easily be tested.

mwjames added a commit that referenced this pull request Oct 21, 2017

@mwjames

This comment has been minimized.

Copy link
Contributor Author

mwjames commented Oct 21, 2017

Back-ported to 2.5.x with 4bc0d5f.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.