Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds in MediaWiki's default script parameters in non-standard setups #2780

Merged
merged 1 commit into from Oct 21, 2017

Conversation

Projects
None yet
2 participants
@kghbln
Copy link
Member

kghbln commented Oct 20, 2017

This PR is made in reference to: #2778

This PR addresses or contains:

  • Adds in MediaWiki's default script parameters in non-standard setups

This PR includes:

  • Tests (unit/integration)
  • CI build passed

Fixes: #2778

@kghbln kghbln requested a review from mwjames Oct 20, 2017

@kghbln

This comment has been minimized.

Copy link
Member Author

kghbln commented Oct 20, 2017

@mwjames I made a hopefully educated guess as to how to add the fix to the scripts that did not have protected function addDefaultParams()

@mwjames mwjames merged commit b89ffb3 into master Oct 21, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@mwjames mwjames deleted the issue-2778 branch Oct 21, 2017

@mwjames

This comment has been minimized.

Copy link
Contributor

mwjames commented Oct 21, 2017

Back-ported to 2.5.x with 55b6b72.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.