Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter categories from transcluded content in `format=embedded`, refs 1455, 2751 #2803

Merged
merged 1 commit into from Nov 5, 2017

Conversation

Projects
None yet
2 participants
@mwjames
Copy link
Contributor

commented Nov 5, 2017

This PR is made in reference to: #1455, #2751

This PR addresses or contains:

  • Fixes " ... that embedding pages may accidentally include category statements if the embedded articles have any categories ..." [0] by preventing transclusion of categories before the source text is returned to MediaWiki
  • Importing of other "foreign" value statements was fixed in #1455

[0] https://www.semantic-mediawiki.org/wiki/Help:Embedded_format

This PR includes:

  • Tests (unit/integration)
  • CI build passed

Fixes #

@mwjames mwjames added the enhancement label Nov 5, 2017

@mwjames mwjames added this to the SMW 3.0.0 milestone Nov 5, 2017

@mwjames

This comment has been minimized.

Copy link
Contributor Author

commented Nov 5, 2017

@kghbln FYI

@mwjames mwjames merged commit b82f2a8 into master Nov 5, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@mwjames mwjames deleted the embedded-cat branch Nov 5, 2017

@mwjames

This comment has been minimized.

Copy link
Contributor Author

commented Nov 5, 2017

@kghbln

This comment has been minimized.

Copy link
Member

commented Nov 5, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.