Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update BeforePageDisplay.php #2856

Merged
merged 4 commits into from Dec 9, 2017

Conversation

Projects
None yet
3 participants
@kghbln
Copy link
Member

commented Dec 8, 2017

This PR is made in reference to: #2852

This PR addresses or contains:

This PR includes:

  • Tests (unit/integration)
  • CI build passed

@kghbln kghbln added the releasenotes label Dec 8, 2017

@kghbln kghbln added this to the SMW 2.5.6 milestone Dec 8, 2017

@JeroenDeDauw

This comment has been minimized.

Copy link
Member

commented Dec 8, 2017

There was 1 failure:

  1. SMW\Tests\MediaWiki\Hooks\BeforePageDisplayTest::testProcess with data set #0 (array(), array(true))

Failed asserting that false is true.

/home/travis/build/SemanticMediaWiki/mw/extensions/SemanticMediaWiki/tests/phpunit/Unit/MediaWiki/Hooks/BeforePageDisplayTest.php:100

@kghbln

This comment has been minimized.

Copy link
Member Author

commented Dec 8, 2017

That's what tests are there for. Adapted the test. Toi, toi, toi ...

@kghbln

This comment has been minimized.

Copy link
Member Author

commented Dec 8, 2017

ok, so alternate = alternate is false. Hmm ...

@JeroenDeDauw

This comment has been minimized.

Copy link
Member

commented Dec 8, 2017

There was 1 failure:

  1. SMW\Tests\MediaWiki\Hooks\BeforePageDisplayTest::testProcess with data set #1 (array(Mock_Title_5be11802 Object (...)), array(false))

Failed asserting that true is false.

/home/travis/build/SemanticMediaWiki/mw/extensions/SemanticMediaWiki/tests/phpunit/Unit/MediaWiki/Hooks/BeforePageDisplayTest.php:95

/home/travis/build/SemanticMediaWiki/mw/maintenance/doMaintenance.php:111

Opposite error this time :)

@kghbln

This comment has been minimized.

Copy link
Member Author

commented Dec 8, 2017

Opposite error this time :)

Do you have a hint for me. I do not know what is going on.

@mwjames

This comment has been minimized.

Copy link
Contributor

commented Dec 8, 2017

@mwjames

This comment has been minimized.

Copy link
Contributor

commented Dec 8, 2017

Update BeforePageDisplayTest.php
Let's see if PHP 7.1 will be happy
@kghbln

This comment has been minimized.

Copy link
Member Author

commented Dec 8, 2017

Looks like we are cool now for a squash and merge. :) Resistance is futile.

@mwjames mwjames merged commit 7dc77ba into master Dec 9, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@mwjames mwjames deleted the issue-2852 branch Dec 9, 2017

@kghbln kghbln removed the releasenotes label Sep 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.