New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Special:Browse to add `SMW_BROWSE_SHOW_GROUP` (property group support) #2874

Merged
merged 1 commit into from Dec 10, 2017

Conversation

Projects
None yet
2 participants
@mwjames
Copy link
Contributor

mwjames commented Dec 10, 2017

This PR is made in reference to: #

This PR addresses or contains:

  • Special:Browse can easily become crowded when plenty of properties (with values) are required to be displayed and following PR tries to counter this by allowing to define property groups
  • Adds SMW_BROWSE_SHOW_GROUP (enabled by default) to support a simple grouping feature in Special:Browse by which properties that are annotated with a group category are being displayed in the same section
  • Adds declarative property Is property group to identify a group category
  • To modify the caption of a group (e.g. Category:Foo bar) the convention key smw-property-group-label- as in smw-property-group-label-foo-bar can be used to modify the group caption and if necessary allows to translate the group using the standard smw-property-group-label-foo-bar/someLang approach
  • The group system is very simple, group membership is a 1:1 (no fancy property X is member of group A and B etc.), class hierarchies are not resolved (property X is member of category B with category B being a subcategory of A where category A is marked as Is property group etc.)

How does it work?

  • SMW_BROWSE_SHOW_GROUP has to be enabled
  • Select a property Foo and add a [[Category:Foo group]]
  • Add [[Is property group::true]] to the Category:Foo group page
  • That's it!
  • Now, when browsing a subject that contains a Foo property, Special:Browse should display a group called Foo group and list property Foo under this group

image

image

This PR includes:

  • Tests (unit/integration)
  • CI build passed

Fixes #

@mwjames mwjames added the feature label Dec 10, 2017

@mwjames mwjames added this to the SMW 3.0.0 milestone Dec 10, 2017

@mwjames mwjames merged commit ea48204 into master Dec 10, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@mwjames mwjames deleted the property-group branch Dec 10, 2017

@mwjames

This comment has been minimized.

Copy link
Contributor

mwjames commented Dec 10, 2017

@kghbln FYI

kghbln added a commit that referenced this pull request Dec 10, 2017

Update de.json
Provides German translation for new special property

Refs: #2874
@kghbln

This comment has been minimized.

Copy link
Member

kghbln commented Dec 10, 2017

Wow, great idea. This is actually a feature that I have been missing for a while.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment