New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Special:Ask add toggle option, minimze options field default size #2893

Merged
merged 1 commit into from Dec 16, 2017

Conversation

Projects
None yet
2 participants
@mwjames
Copy link
Contributor

mwjames commented Dec 16, 2017

This PR is made in reference to: #

This PR addresses or contains:

  • #2611 removed the user-preference toggle since the JS was totally broken but allowing the option section to take a dominating role on the screen seems counter productive when one "just" wants to execute a query
  • The default size of the option field section is now minimized, [ + ] can be used to expand on the available parameters with a collapsed section showing a fading input progression indicating the availability of additional parameters
  • #2891 introduced a flex mode and with the help of the collapsed option section another step is made to ease the navigation of Special:Ask on small screens

image

image

This PR includes:

  • Tests (unit/integration)
  • CI build passed

Fixes #

@mwjames mwjames added the feature label Dec 16, 2017

@mwjames mwjames added this to the SMW 3.0.0 milestone Dec 16, 2017

@mwjames mwjames merged commit bd6c842 into master Dec 16, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@mwjames mwjames deleted the ask-options-toggle branch Dec 16, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment